Repository navigation
fix: validate layer names before extraction and name the missing input column - #214
Merged
Merged
Conversation
This was referenced Nov 5, 2026
KartikP
added a commit
to brain-score/vision
that referenced
this pull request
Nov 5, 2026
Vision half of the new-user onboarding fixes. Paired with KartikP/brainscore-unified#73 (description, examples) and brain-score/core#214. - `ActivationsExtractorHelper` reads image paths from an `image_path` column when a stimulus set has no `stimulus_paths` (sets built from a table). Packaged sets keep the `stimulus_paths` lookup. A set with neither raises a `ValueError` naming the column to add. - `PytorchWrapper.layer_names()` declares its recordable layers (relative to the wrapped module, plus `logits`), used by core to validate layer paths before any forward pass. No model plugins are changed. `umi-v2.yml` points at unified `f03ca78`. Tests: `tests/test_model_helpers/activations` 42 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core half of the new-user onboarding fixes. Paired with KartikP/brainscore-unified#73 (description, examples) and brain-score/vision#2638.
region_layer_maplayers are checked whenBrainScoreModelis built, and rawstart_recordingtargets when recording starts, against the routed extractor's optionallayer_names(). A missing layer raisesValueErrorwith close matches before any forward pass. Extractors that do not declarelayer_names()skip the check.Extractorprotocol documents the optionallayer_names().umi-v2.ymlpoints at unifiedf03ca78, which pins this branch'sc8cda87and vision89dfca1.Tests: core 1205 passed; the remaining 1 failure (
test_conda_score, exit 127) and 7 errors (test_plugin_management/test_test_plugins.py,test_submission/test_endpoints.py) also occur onunified-model-interface-v2locally.