feat: add span customizers (SDK-316) - #788
Draft
Andrew Kent (realark) wants to merge 2 commits into
Draft
Andrew Kent (realark) wants to merge 2 commits into
Andrew Kent (realark) wants to merge 2 commits into
Conversation
Contributor
Author
|
Fixed the CI regression in 5111069. The Discovery Engine subprocess test treated every Verification:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Generated Description
Summary
Implements SDK-316 using the span customizer specification and the JavaScript reference.
SpanCustomizer.on_span_export,SpanExportData,set_span_customizers, andauto_instrument(span_customizers=...).Verification
test_types: pyright/mypy clean, 35 runtime tests passed.The core suite required clearing local Braintrust endpoint environment overrides to match recorded cassettes. It exits successfully but prints an atexit closed-output-stream warning. No cassettes were changed.
Contract note
Like JavaScript, failures are fail open. Throwing is not a safe way to block export; the API docs state this explicitly.