Repository navigation
chore(ci): warn when a change touches downstream-mirrored files - #8765
Open
kevinpschaaf wants to merge 2 commits into
Open
kevinpschaaf wants to merge 2 commits into
kevinpschaaf wants to merge 2 commits into
Conversation
A small subset of this repo is mirrored into a downstream internal repository. Changing one of those files requires a sync, and today there is nothing that says so — the drift is only noticed later, downstream. Adds a check with two entry points sharing one detection script: - A pre-push hook that prints a loud banner listing the affected files. Never blocks; it is there so the need for a sync is known before the PR is even opened. - A GitHub workflow that annotates each changed mirrored file and fails until the PR description contains the literal token ACK_SYNC_REQUIRED. A warning gets scrolled past, a red X does not, and the token makes these PRs greppable later. The list of mirrored files lives in .github/mirrored-files.txt, whose header also carries the sync procedure and the constraints that apply to mirrored code (limited imports, the private-field rewrite, and so on). Also available locally as `npm run check:mirror`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small subset of this repo is mirrored to an internal repo.
Adds a check with two entry points sharing one detection script:
The list of mirrored files lives in .github/mirrored-files.txt, whose header also carries the sync procedure and the constraints that apply to mirrored code (limited imports, the private-field rewrite, and so on).
Also available locally as
npm run check:mirror.