Skip to content

Add searching for places - #251

Merged
natekspencer merged 5 commits into
bretterer:mainfrom
walthowd:feat/place-search
Nov 15, 2026
Merged

natekspencer merged 5 commits into
bretterer:mainfrom
walthowd:feat/place-search

Conversation

@walthowd

@walthowd walthowd commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Builds on #250.

  • search_places: the app's map search. Returns place id, name, address, coordinates, and driving distance and time.
  • suggest_places: autocomplete suggestions for type-ahead
  • utils.place_url: the app's link for a result. Sending it with send_location_to_vehicle makes the vehicle show the place's name.

No paired phone key needed.

Tested

Against the live API: searches return in under a second, suggestions in about 0.1 s. The API ignores maxResults, so there's no limit parameter.

@natekspencer

Copy link
Copy Markdown
Collaborator

#252, #246 and #248 have been merged, so this now conflicts with main (tests/test_rivian.py). Could you rebase onto main and resolve the conflicts? If #249 and #250 are in by then, rebase after them.

They will land in this order, so rebasing in the same order keeps the later ones from conflicting again:

  1. Pass subscription errors to an on_error callback #249 Pass subscription errors to an on_error callback
  2. Add starting a Gear Guard live stream #250 Add starting a Gear Guard live stream
  3. Add searching for places #251 Add searching for places
  4. Add climate hold and pet mode commands #247 Add climate hold and pet mode commands
  5. Add Parallax equivalents of vehicle commands #245 Add Parallax equivalents of vehicle commands

I've moved this to draft for now; please mark it ready for review once it's rebased.

The server ends a subscription with an `error` message when it fails, for
example when the vehicle refuses a command the subscription waits on. The
web socket only logged those at debug, so a caller waiting on the
subscription could only time out. Subscriptions can now take an `on_error`
callback that gets the error message; existing callers are unchanged.
An `on_error` that raised escaped the receive loop and ended the receiver
task. Both callbacks now run through `_run_callback`, which logs a failure
instead of raising and awaits coroutine callbacks.
`start_gear_guard_live_stream` starts a live camera stream the way the
Rivian app does and returns its Kinesis Video WebRTC config (signaling
endpoint, ICE servers and role), for a viewer to join:

- It subscribes to `gearGuardLiveConfig` with a fresh command id, then sends
  the signed `security.video_monitoring.start_live_streaming` command with
  that same id; the cloud routes the config by it.
- `parallax.encode_live_streaming` builds the command's payload from a new
  `LiveStreamingRequest` schema; `GEAR_GUARD_CAMERAS` names the cameras.
- A refused start (e.g. a camera the vehicle doesn't have) raises
  RivianApiException straight away, through the subscription's `on_error`.

It needs Gear Guard video monitoring on and a paired phone. The vehicle
serves one session at a time, about 3 minutes each and an hour a day.

Builds on bretterer#249.

Verified against a 2026 R1S (Gen 2) running 2026.36.01: the config arrived
within seconds of the start when the vehicle was awake, and the front and
right cameras streamed in a WebRTC viewer. A sleeping vehicle can take
longer to wake than the default 40 second timeout. Not tested: the rear,
left and bed cameras, the R2's cabin camera.
A refusal that reached the future before the start command was rejected
was never read, so asyncio logged "Future exception was never
retrieved"; it is now read before returning. The error handler also
takes a `payload` sent as an object, not only as a list, so it still
fails the start instead of raising in the callback.
- `search_places` searches like the Rivian app's map search (its `places`
  query): results with a Google place id, name, address, coordinates and
  the driving distance and time from where you search.
- `suggest_places` returns the app's suggested search texts for partial
  text (the same query with autocomplete), such as "restaurants" and "Red
  Lobster" for "RE", for type-ahead in front of `search_places`.
- `utils.place_url` builds the Rivian app's link for a result, which
  `send_location_to_vehicle` sends so the vehicle shows the place's name.

None of them needs a paired phone key.

Tested against the API: a search returned Google's results in under a
second, in their own order rather than nearest first, and suggestions came
back in about a tenth of a second. `maxResults` was ignored, so it is left
out.
@walthowd
walthowd marked this pull request as ready for review November 15, 2026 20:31
@walthowd

Copy link
Copy Markdown
Contributor Author

Rebased onto #250 in your merge order (so the diff shows #249/#250 until they land), ready for review.

@natekspencer natekspencer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

@natekspencer
natekspencer merged commit 95131ce into bretterer:main Nov 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants