Repository navigation
test: cover iOS persisted maxConcurrentTasks restore - #93
Merged
Merged
Conversation
Extract persistedLimit(defaults:) from the static initializer so the value a cold-started process will use is unit-testable; add tests for restore + enforcement and invalid persisted values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cold start on iOS (BGTask launching the app without Dart initialize) cant be driven on a simulator or from flutter run, so the part I can check is: what limit does a fresh process build from what was persisted.
Pulled the UserDefaults read out of the static initializer into persistedLimit(defaults:) (same behaviour, plus ignores non-positive/non-int values) and added tests: restore from a persisted value and enforce it with a brand new limiter, default when nothing is stored, invalid stored values fall back to 4. Ran in a temp macOS package (5 limiter tests pass), example app still builds for the simulator.
End-to-end BGTask cold start on a device is still not verified.