ci(nixos): retire the preview label from the testable PR build - #618
Open
mrosseel wants to merge 1 commit into
Open
ci(nixos): retire the preview label from the testable PR build#618mrosseel wants to merge 1 commit into
mrosseel wants to merge 1 commit into
Conversation
The preview label did nothing testable did not. Both job conditions accepted either, and nothing downstream inspected which one was applied: update_manifest.py never receives a label and writes every PR build into channels["unstable"]. This repo has no preview label, so the condition was dead; the label existed only on the mrosseel fork, where it has now been deleted and testable's description corrected to say it publishes to the unstable channel. Both actions/checkout allow-unsafe-pr-checkout opt-ins are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previewdid nothingtestabledid not.Both job conditions in
nixos-pr-build.ymlaccepted either label, and nothing downstream inspected which one was applied —update_manifest.pynever receives a label and writes every PR build intochannels["unstable"]. So the two were exact synonyms.This repo has no
previewlabel at all, so the condition was dead code here. The label existed only on themrosseelfork, where it has now been deleted;testable's description there was also corrected — it claimed "Triggers CI build for testing (no channel publish)", which was never true.Four mention sites removed: the header comment, both job
if:conditions, and the twoallow-unsafe-pr-checkoutcomments. Bothallow-unsafe-pr-checkout: trueopt-ins themselves are untouched, and the workflow still parses with both remaining conditions gating ontestablealone.Branched off
mainso the diff is this one file.🤖 Generated with Claude Code