Repository navigation
Document that the report summary covers only the step's tests - #345
Merged
Merged
Conversation
bdc_create_report() recomputes "Summary of all tests" from the tests of the requested step, so in the space vignette it reports 8 records while the .summary column, which bdc_summary_col() builds from every "." column including .uncer_terms, flags 9. The help page now explains this and a test pins it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019P8b9MT61Yto9NRYBksGtb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents existing behaviour; no code change.
New
@detailsinbdc_create_report()says the summary row counts only the step's tests and can be smaller than the.summarycolumn.Evidence
Seen in the regenerated space vignette (#344): the report's "Summary of all tests" is 8, the
.summarycolumn flags 9 (the extra record fails only.uncer_terms).New test,
.uncer_terms = c(F, F, T, T),.rou = c(T, T, T, F):.rou1,.summary1bdc_summary_col(): 3 flaggeddevtools::test(filter = "bdc_create_report"):FAIL 0 | PASS 54.Merge Danger
Door: two-way
Blast Radius: docs
Help page and one test only.
🤖 Generated with Claude Code
https://claude.ai/code/session_019P8b9MT61Yto9NRYBksGtb