Skip to content

Match branch names using regex. fixes #1#4

Open
dawkaka wants to merge 3 commits into
bubunyo:masterfrom
dawkaka:main
Open

Match branch names using regex. fixes #1#4
dawkaka wants to merge 3 commits into
bubunyo:masterfrom
dawkaka:main

Conversation

@dawkaka

@dawkaka dawkaka commented Aug 8, 2022

Copy link
Copy Markdown

Examples:
Screenshot from 2022-08-08 12-40-17
Screenshot from 2022-08-08 12-41-36
Screenshot from 2022-08-08 12-43-49

Invalid regex:
Screenshot from 2022-08-08 12-42-18

@dawkaka dawkaka changed the title Match branch names using regex fixes #1 Match branch names using regex. fixes #1 Aug 8, 2022

@bubunyo bubunyo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your changes on top of master so that your changes are a bit clear. Also it would be nice it you used test cases to validate your changes.

@dawkaka dawkaka changed the base branch from main to master August 8, 2022 21:17
@dawkaka

dawkaka commented Aug 9, 2022

Copy link
Copy Markdown
Author

Please rebase your changes on top of master so that your changes are a bit clear. Also it would be nice it you used test cases to validate your changes.

The searcher function is not in global scope, can't test without changing almost all the code

@bubunyo

bubunyo commented Aug 17, 2022

Copy link
Copy Markdown
Owner

it is not meant to be. you can implement the searcher as a local function and use test cases to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants