Repository navigation
fix: Report incomplete ingestion parsing and extraction - #798
Draft
buildingjoshbetter wants to merge 5 commits into
Draft
buildingjoshbetter wants to merge 5 commits into
buildingjoshbetter wants to merge 5 commits into
Conversation
This was referenced Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Outcome-reporting foundation for #768, stacked on
fix/ingestion-recall-invalidation-769. This provides evidence for later durable completion and recovery work. It does not activate new pipeline/CLI completion, storage receipts, retry guards or automatic replay.Changes
Pathobjects remain files even when missing. Preserve the existing list parser's functions and format selection.Validation
Windows and dependency corrections
Windows CI exposed a test-loader default-encoding failure and a real capture-identity failure. Source loaders now specify UTF-8. The remaining diagnostic showed only
ctime_nsdiffering between descriptor and pathname observations, matching CPython Windows stat/fstat semantics.The final identity observation now reopens the pathname read-only and uses fstat without rereading content. It preserves every identity/timestamp comparison, captured hash and byte count. Tests cover genuine timestamp changes, replacement, deletion, denied reopen and handle cleanup. Pre-fix Windows semantics fail the new control; removing ctime checks fails genuine-change controls. A stable capture still does not lock the source against later changes.
This branch also incorporates the #801 MCP/Pydantic dependency correction. Final head
f4c091a6992679be24ef9edb11c5e3a6a0ffcbd6passed the isolated Linux suite above; log SHA2567462d1d99439832dacdd201a88b7741cb16639fcfce5c259ec73068949ce7f11. Fresh hosted Windows and dependency-boundary CI remain pending.Limits and next steps
The detailed file API still reads full bytes and decoded text. Its stable flag concerns capture time only, not later appends or completion. Legacy salvage remains uncapped per response before the existing final merge cap. Invalid envelopes can retain legacy-selected facts while reporting failed coverage; partial facts must not be treated as completed extraction.
The existing pipeline and CLI are not yet switched to these outcomes. Durable per-operation receipts, storage commit-then-raise ambiguity, partial extraction recovery, Stop-hook markers and drain/retry coordination remain unresolved work under #768. This draft does not certify ingestion completion or implement archive-level Deep Search.
Draft only. #768 remains open. No main merge, release or live-service change. Historical repository contents are outside the new-change privacy scan.