Repository navigation
fix: Preserve daemon defaults across explicit tier requests - #804
Draft
buildingjoshbetter wants to merge 3 commits into
Draft
buildingjoshbetter wants to merge 3 commits into
buildingjoshbetter wants to merge 3 commits into
Conversation
This was referenced Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refs #795. Prevent a request for an explicit embedding tier from silently changing the daemon's default model. Reuse an already loaded model across equivalent built-in tier names.
This is a prerequisite for safe tier preparation. Issue #795 remains open for target-bound preparation, bounded rebuild lifetime and coordinated activation.
Changes
qwen3migration error, including whitespace and case variants.base/pro/qwen3_256and foredge/model2vecwhen the resolved built-in identity matches.Validation
GPUBox isolated full suite: 2,182 passed, 22 skipped, 3 deselected; 420 subtests passed.
TRUEMEMORY_TEST_NATIVE_VEC=1; network disabled; generated fixtures only. Configured Ruff and Python 3.10 syntax checks pass. New diffs and commit identities pass publication checks.Full-run log SHA256:
d88501c185f9e37e020d3e5ed6bc73057723862679ddd50543a0dd7eebcaa0e8.Eighteen focused cases exercise alias reuse, explicit-target nonmutation, custom/fallback boundaries, removed-name validation from the actual resolver, initial-load concurrency, expiration, OOM invalidation and native slice ceilings with model fakes.
An earlier private full run failed six cases. Investigation found that re-resolving an already loaded implicit tier could change vector spaces after a waiting query resumed. The correction preserves all original concurrency and deadline-recovery assertions. Only the historical assertion that the main path must mutate global selection was intentionally changed to require no mutation. Four new controls fail against the earlier implementation and pass with the correction. A separate removed-name control also failed against the earlier pure resolver. Failed run evidence is retained; the failed snapshot was not pushed.
Limits
No native model performance improvement is claimed here. Distinct replacement construction can still overlap old model references, and the optional fast CPU model has a separate lifetime. This does not implement a target protocol for older daemons, change tier-switch callers/configuration, or complete the whole-process memory budget.
The separate batch-layout retrieval regression on #735 remains held. This change does not alter model weights, precision, dimensions, reranker selection or retrieval depth.