Repository navigation
fix: Preserve exact source values across legacy rebuilds - #805
Draft
buildingjoshbetter wants to merge 1 commit into
Draft
buildingjoshbetter wants to merge 1 commit into
buildingjoshbetter wants to merge 1 commit into
Conversation
This was referenced Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Follow-up for #756, stacked on #802. Prevent legacy-schema source changes from escaping the streamed rebuild publication fence. This does not activate tier switching or close the broader issue.
Reproduced defect
SQLite formats REAL values as text when casting them to BLOB. Adjacent representable numbers can therefore have identical casts while producing different separation input strings. The previous byte/type predicate could allow a rebuild to publish vectors after such a source edit. SQL numeric equality also cannot distinguish retained positive and negative REAL zero.
Changes
Validation
aca318473f556e269b99960a18512c5b65dfeb9a3930ab1489cffa3e9116eaad.Limits
The zero predicate deliberately favors safe invalidation over retaining a certificate for a same-zero source assignment. Generated fields and custom UNIQUE schemas retain conservative behavior. Raw numeric content is not claimed as a supported embedding input; the publication regressions use valid separation strings.
Canonical maintenance/FTS comparison and untracked schema-interval trust are separate follow-ups. No native performance, whole-process memory or MPS/thermal improvement is established here. Models, rerankers, precision, dimensions and retrieval limits are unchanged. Test inputs are generated; no personal memories, transcripts or credentials are included. No main merge, release or issue closure.