Repository navigation
fix: Add cancellable style maintenance with verified coverage - #812
Draft
buildingjoshbetter wants to merge 8 commits into
Draft
buildingjoshbetter wants to merge 8 commits into
buildingjoshbetter wants to merge 8 commits into
Conversation
# Conflicts: # docs/resource-budgets.md
This was referenced Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Tracked style-rebuild foundation for #747, stacked on #809 and including the #808/#810 maintenance prerequisites. This draft implements checkpoint A only. Incremental coverage and automatic routing remain required before release or issue closure.
Problem and correction
Legacy style accumulators need a source rebuild, but an untracked synchronous rebuild can block foreground work, publish stale output, or lose the previous generation on cancellation. A private
style_vectorsadapter now uses the existing maintenance runner and its outer publication transaction.This draft does not activate automatic style work, rebuild during a getter, reconstruct raw sums from normalized profiles, or change models, dtype, dimensions, rerankers or retrieval limits. Public low-level builders retain their existing SQLite-fenced contract.
Validation
fea826751f4265111487d1fb20aac844559ff4bb8488785d2e0fae93dfb08bfa.32f66c4483ed4414ec63c17ce6c413d621dbf2ca71de62423a4c38276552edfa.Earlier failed receipts are retained. A previous revision failed five existing recovery checks after adding a keyword to positional wrappers. This correction narrows the new behavior to style maintenance; it does not weaken those tests. Adversarial review also caught read contention after preparation and distinguished witnessed cancellation from an unexplained lost transaction.
Release requirements and limits
Checkpoint B must advance source coverage atomically with ordinary appends, avoid double counting and prove 75 current appends cause zero extra full style builds. Checkpoint C must route startup, explicit and bulk work through coalesced ownership and report bounded style health. Neither is implemented by this draft.
Synthetic transaction tests establish the scoped correctness properties. They do not establish native latency, memory, MPS or thermal improvement. Only generated synthetic test data was used; no personal memories, transcripts or credentials. No main merge, issue closure or release.