Repository navigation
fix: Bound tier rebuild OOM recovery - #821
Draft
buildingjoshbetter wants to merge 1 commit into
Draft
buildingjoshbetter wants to merge 1 commit into
buildingjoshbetter wants to merge 1 commit into
Conversation
This was referenced Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persistent tier-rebuild OOM could retry the same singleton until the 9000-second timeout while cache cleanup still retained the failed forward's traceback. A failed rollback could also enter nested retries and report completion for uncommitted vectors.
Move recovery outside the exception handler and bound failed paired batches at an unchanged source offset to
2 * (floor(log2(N)) + 1), where N is the first failed actual batch length. The effective retry size cannot grow. Each halving phase gets two failures, including one cleanup retry at singleton size. Progress resets the recovery budget only after the vector pair and checkpoint commit. Cancellation and timeout are rechecked before recovery starts another native batch.A still-active owned transaction after failure now propagates to the manager for connection closure before retry or status publication. The last stored status may remain running because writing a replacement through that uncertain transaction is unsafe. Clean status rollback remains best-effort; borrowed savepoint behavior is unchanged.
Stacked on #818, which already includes #788's paired-write foundation and the reviewed MCP compatibility correction. This diff contains only the worker change, its new tests and the resource-budget documentation addition. Existing tests, model identities, rerankers, dtype, retrieval policy and successful normal batching are unchanged. Refs #297 and #752.
Validation:
54e4a44a67cf434450f38f54a9188d5b2660d73858f510ab630a1602e6f070ae.80739f1d8a42b29d238ea1d6c8fbe0855d3dc5bbc5c60735d3e5461d16265515.This bounds repeated nonprogress and releases the handler's traceback reference before cleanup. It does not bound one native call, allocator bytes or the retained full source list. Original Mac memory use, MPS calibration and whole-process acceptance remain unproven. Draft only; no merge or release.