Repository navigation
fix: Bound reranker input length and attention memory per batch - #836
Draft
buildingjoshbetter wants to merge 4 commits into
Draft
buildingjoshbetter wants to merge 4 commits into
buildingjoshbetter wants to merge 4 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local reranker and the model server ran the cross-encoder with its full 8,192-token limit and a fixed 64-pair batch. Attention scratch grows with batch × length², so one request with long pairs could need tens of GB. On a Mac, that request first fails with an MPS out-of-memory and is then retried on CPU, where it keeps allocating.
This change:
predictcall untouched when every default batch already fits, and for models without a tokenizer and an integermax_seq_length(proxies, older or custom encoders).Real ModernBERT reranker on CPU, 100 synthetic candidates, 16 GiB container, peak cgroup memory before → after:
Validation at f1f7655, stacked on #835:
Limitation: a cross-encoder that reports
max_seq_lengthas None is neither capped nor budgeted. The shipped ModernBERT and MiniLM rerankers report integer limits.Base is
maintenance/remaining-code-only-v2(#835). Draft; no merges or releases.