Conversation
- Replace removed driver query methods (execute, getScalar, getIterator) with the new DatabaseExecutor API - Add getExecutor() to Migration, DatabaseInterface and AbstractDatabase - Rename getDbDriverWithoutDatabase() to getExecutorWithoutDatabase() - Update PgsqlDatabase::createDatabaseIfNotExists() to receive DatabaseExecutor - Upgrade PHPUnit to ^12.5 - Pin SQL Server image to 2022-latest and use MSSQL_SA_PASSWORD - Add CHANGELOG-6.0.md and CHANGELOG-7.0.md - Document getExecutor() in the API reference
Widen the PHP constraint to ">=8.3 <8.7"; the previous "<8.6" is exclusive and excluded PHP 8.6. Bump byjg/* dependencies to ^7.0. While 7.0 is unreleased these resolve to 7.0.x-dev from each component's 7.0 branch, via minimum-stability dev with prefer-stable. Pin PHPUnit to ^12.5 and move Psalm to tools/psalm/composer.json. Psalm enumerates supported PHP versions and no release lists 8.6, so as a require-dev it made "composer install" fail on the 8.6 build before any test ran. "composer psalm" bootstraps the tool and runs it. CI: add PHP 8.6 to the matrix; the Psalm job runs on 8.5. Housekeeping: rename phpunit.xml.dist to phpunit.xml, carry the 6.0 changelog onto this branch, and update CHANGELOG-7.0.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades the library to
byjg/anydataset-db7.0 and bumps the migration version to 7.0, aligning it with the anydataset-db major version.Changes
execute,getScalar,getIterator) with the newDatabaseExecutorAPIgetExecutor(): DatabaseExecutortoMigration,DatabaseInterface, andAbstractDatabasegetDbDriverWithoutDatabase()togetExecutorWithoutDatabase()(now returnsDatabaseExecutor)PgsqlDatabase::createDatabaseIfNotExists()to receive aDatabaseExecutor^12.52022-latestand useMSSQL_SA_PASSWORDin docker-composeCHANGELOG-6.0.md(released 6.0) andCHANGELOG-7.0.mdwith the full upgrade pathgetExecutor()in the API referenceBreaking Changes
$migration->getDbDriver()must switch to$migration->getExecutor()(transactions stay on the driver)DatabaseInterfaceimplementations must addgetExecutor()(inherited when extendingAbstractDatabase)See
CHANGELOG-7.0.mdfor the detailed upgrade path.Testing