fix(bindgen): fix string flat lowering of multibyte utf-8 and multiunit utf-16 chars - #1838
Merged
Merged
Conversation
lann
changed the title
vados-cosmonic
approved these changes
Aug 6, 2026
vados-cosmonic
left a comment
vados-cosmonic
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🚀
Thanks for fixing this and updating the test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTF-8 length was lowered as codepoints instead of bytes, breaking on multibyte chars.
UTF-16 length was lowered as codepoints instead of code units, breaking on multi-unit chars. Additionally, the UTF-16 lowering was redundantly re-encoding the string - possibly a refactoring mistake?