fix(bindgen): fix utf-8 to utf-16 transcode length calculation - #1840
Merged
Conversation
vados-cosmonic
approved these changes
Aug 6, 2026
vados-cosmonic
left a comment
vados-cosmonic
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🚀
Thanks or the fix here -- there is an issue out for a UTF16 component test, so I'll try to add that as a follow up at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mistakenly doubling the length of the array view (presumably thinking the Uint16Array length was in bytes). I renamed the var from
strlentocodeUnitsso that the next person to see it will at least stop and think "what the heck is a code unit?".This only rarely triggered a real bug; if the destination was near the end of the Memory and/or the string was long enough then it could overflow, triggering
RangeError.