Add epoch deadline callback binding to Store - #373
Merged
martindevans merged 1 commit intoAug 16, 2026
Conversation
Wasmtime's `wasmtime_store_epoch_deadline_callback` was unbound, so the only way to bound wasm execution was a single `SetEpochDeadline` fixed at call start. Stopping a running guest early meant incrementing the engine-wide epoch, which traps every other in-flight store sharing the engine. `Store.SetEpochDeadlineCallback` binds it: the callback runs on the executing thread when the deadline is reached, and either returns a new relative deadline to resume with, or throws to terminate the execution. A throwing callback surfaces to the caller as the inner exception of a `WasmtimeException`, using the same `CallbackErrorCause` mechanism as host function callbacks, so a host can renew a short deadline per tick and stop the guest on cancellation. Yielding (`WASMTIME_UPDATE_DEADLINE_YIELD`) is not exposed, as it requires async support this binding does not enable. Covered by tests for deadline renewal, callback replacement and null arguments.
martindevans
approved these changes
Aug 16, 2026
martindevans
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for working on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasmtime's
wasmtime_store_epoch_deadline_callbackwas unbound, so the only way to bound wasm execution was a singleSetEpochDeadlinefixed at call start. Stopping a running guest early meant incrementing the engine-wide epoch, which traps every other in-flight store sharing the engine.Store.SetEpochDeadlineCallbackbinds it: the callback runs on the executing thread when the deadline is reached, and either returns a new relative deadline to resume with, or throws to terminate the execution. A throwing callback surfaces to the caller as the inner exception of aWasmtimeException, using the sameCallbackErrorCausemechanism as host function callbacks, so a host can renew a short deadline per tick and stop the guest on cancellation.Yielding (
WASMTIME_UPDATE_DEADLINE_YIELD) is not exposed, as it requires async support this binding does not enable.Covered by tests for deadline renewal, callback replacement and null arguments.