Wasmtime debug instrumentation: remove stale comment about moving GCs. - #14095
Open
cfallin wants to merge 1 commit into
Open
Wasmtime debug instrumentation: remove stale comment about moving GCs.#14095cfallin wants to merge 1 commit into
cfallin wants to merge 1 commit into
Conversation
We previously noted that instrumentation slots were not seen by a GC, and only implicitly rooted (by live program values) for a non-moving GC. However as part of landing debug support, we eventually had to add proper rooting; the GC now explicitly scans instrumentation slots on the stack as well as the user stackslots. So this comment is out-of-date, and moving GCs work fine with debug (which is great, because we have one now!). Fixes bytecodealliance#13798.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously noted that instrumentation slots were not seen by a GC, and only implicitly rooted (by live program values) for a non-moving GC. However as part of landing debug support, we eventually had to add proper rooting; the GC now explicitly scans instrumentation slots on the stack as well as the user stackslots. So this comment is out-of-date, and moving GCs work fine with debug (which is great, because we have one now!).
Fixes #13798.