docs(onboarding): make deploy/compose the primary onboarding path (#109) - #215
Merged
Merged
Conversation
Collaborator
Author
|
CI is green. I cannot approve or merge: I am the author. Needs @PeterGuy326 or @Bindy-lbb. |
Collaborator
Author
|
请评审合入(作者是我,不能自批)。 README 主路径改为 需要 @PeterGuy326 或 @Bindy-lbb 批准。 |
PeterGuy326
approved these changes
Sep 18, 2026
PeterGuy326
left a comment
Collaborator
There was a problem hiding this comment.
Independently reviewed current head 0ca8b53 against base 1b27aac. The documentation diff is scoped to onboarding guidance and platform-equivalent local development instructions; git diff --check passes and the required CI checks are green. The unavailable clean-host Docker run is explicitly disclosed in the validation ledger. No blocking finding remains; approving as a non-author CODEOWNER.
PeterGuy326
force-pushed
the
docs/109-compose-first-onboarding
branch
from
September 18, 2026 03:00
0ca8b53 to
1eb33bf
Compare
README now leads with generate-env → compose up → register. Bare-metal dev_up.sh is demoted, and RUN_LOCAL.md records Ubuntu/Debian and WSL2 equivalents for the brew-only steps.
PeterGuy326
force-pushed
the
docs/109-compose-first-onboarding
branch
from
September 18, 2026 03:22
1eb33bf to
6f8fdfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirement and scope
Re-lands the #109 onboarding repositioning on an organization branch. Previous candidate #148 was closed because it was a fork head without CI, not because the content was rejected.
Refs #109 R1: REQ-001–003 / AC-001–003.
Changes
deploy/compose(generate-env→compose up --wait→curl /healthz→ register athttp://localhost:8080→ CLI). Commands matchdocs/DEPLOYMENT.md../scripts/dev_up.shis a development-only subsection.docs/RUN_LOCAL.mdis labeled development-only and adds macOS / Ubuntu/Debian / WSL2 equivalents for PostgreSQL+pgvector, MinIO, Ollama, and the TESTING.md toolchain pins.[Unreleased]changelog entry.AC-003 (first-run messaging) is already satisfied on
mainbymem doctor/ no-credential hints namingdeploy/compose(#112). This PR does not retouch that code.Validation ledger
generate-env/compose.yaml/curl :8080/healthzdeploy/composeon a clean machinecmds_doctor_test.goon maingit diff --checkNo merge, release, or issue closure is claimed. Independent review still required.