Skip to content

feat(mobile): phone shell and phone-link command channel - #357

Closed
waterbro-8 wants to merge 3 commits into
mainfrom
feat/mobile-review
Closed

waterbro-8 wants to merge 3 commits into
mainfrom
feat/mobile-review

Conversation

@waterbro-8

Copy link
Copy Markdown
Collaborator

Summary

Review request for the hosted RoleWeave mobile work that was previously pushed to product master without a PR.

  • Native phone shell (org / command / desktop / settings) instead of a scaled VNC desktop
  • phone-link.v1: phone claims a running desktop and sends one command at a time
  • Org list follows the desktop’s open workspace (no host paths in the snapshot)
  • Settings can revoke this phone’s pairing

Related existing PRs: #330 #337. This branch is the asteam-hosted slice (deploy/ + start.sh + phone-link).

Test plan

  • node --test packages/phone-link/test/*.test.mjs apps/desktop/test/phone-link-host.test.cjs
  • node --test scripts/test/mobile-surface.test.mjs scripts/test/mobile-web-server.test.mjs
  • Phone UA hits / and sees the mobile shell
  • Command tab can claim and submit; busy employee returns busy

Hosted RoleWeave: native phone shell instead of scaled VNC, phone-link.v1
to send commands to a running desktop, live org snapshot, and device revoke.
@waterbro-8

Copy link
Copy Markdown
Collaborator Author

Cleanup after 胡奕舟 2026-09-19 09:21「你们的 pr 清理一下」。

This PR overlaps landed roleweave #337 (merge SHA b732a25fe026e6da4135e143828a6e2e52524ebf): the three-OS phone web shells now live in apps/mobile-web/. Current head is CONFLICTING, Node/smoke/installer CI FAILURE, no reviews.

Closing so it does not sit dirty on main. Unique packages/phone-link work (if still wanted) should be a focused follow-up PR, not this tree.

@waterbro-8 waterbro-8 closed this Sep 19, 2026
@waterbro-8

Copy link
Copy Markdown
Collaborator Author

Reopening to fix CI lockfile + the three review notes you listed (duplicate app.mjs, missing shared assets, double Added). Not treating #337 as a substitute for this phone-link PR.

@waterbro-8 waterbro-8 reopened this Sep 19, 2026
- npm install --package-lock-only so CI sees the new workspace package
- generic deploy/mobile/app.mjs is a one-line import of /shared/shell.mjs
- drop resolvePublicAsset routes for missing org.mjs / command.mjs
- merge the extra Unreleased ### Added heading
Leave /claim unauthenticated until product decides.
@waterbro-8

Copy link
Copy Markdown
Collaborator Author

Reopened and pushed 5e5ce0a on feat/mobile-review after your 14:09 notes.

  • package-lock.json now includes workspace @roleweave/phone-link (npm install --package-lock-only --ignore-scripts).
  • deploy/mobile/app.mjs is the same one-line import "/shared/shell.mjs" as the platform shells.
  • resolvePublicAsset no longer maps /shared/org.mjs or /shared/command.mjs (those files do not exist). /shared/shell.mjs stays.
  • Unreleased CHANGELOG no longer has two ### Added headings.
  • /claim left unauthenticated pending a product call.

I am not a CODEOWNER and will not merge. CI is re-running on this head.

#357

@waterbro-8

Copy link
Copy Markdown
Collaborator Author

Retrigger hosted CI: Git Data API push on 5e5ce0a did not enqueue verify. Reopening immediately.

@waterbro-8 waterbro-8 closed this Sep 19, 2026
@waterbro-8

Copy link
Copy Markdown
Collaborator Author

Reopened to fire pull_request workflows on head 5e5ce0a (lockfile + shell import + dead routes + CHANGELOG).

@waterbro-8 waterbro-8 reopened this Sep 19, 2026
@waterbro-8

Copy link
Copy Markdown
Collaborator Author

再次核对后关闭:#337 已把三端手机 Web 壳合入 apps/mobile-web/,本 PR 的 deploy/mobile 与 deploy/ 壳仍与主干重复且当前 head CONFLICTING;本次触发 CI 也没有生成 check。packages/phone-link / phone-link-host 是独立能力,若继续请从最新 main 单独开 PR,补齐 relay/device-token 契约、认证边界和端到端测试,避免把重复壳与未验收 relay 绑在一起。

@waterbro-8 waterbro-8 closed this Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant