Repository navigation
fix(conversation): preserve shortcuts and IME-safe multiline drafting - #383
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates #321 (by @PeterGuy326) as an in-repo branch; fork PRs cannot satisfy the required CodeQL check name in branch protection. Content rebuilt verbatim from the fork head (all five file blobs byte-identical, CHANGELOG entry re-inserted).
Supersedes #311. Keeps configurable send shortcuts while making Enter-send mode support Ctrl/Cmd+Enter multiline insertion at the caret (including selection replacement), preserves Shift+Enter and IME composition safety, and retains the accepted-to-processing-to-completed progress interaction tests. Rebuilt on the latest main to avoid the stale-file and packaging regressions of the original PR.
Original review history lives on #321 (approved by sun-970). Supersedes #321.