Repository navigation
Add pytest to CI - #6
Merged
Merged
Conversation
…Chromium), fix the CADET-Process dependency name, run ruff CI on main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/tests.yml: conda (viaenvironment.yml, for the real CADET-Core binary) + a pinned CADET-Process dev-branch commit + headless Chromium, thenpytest -v. Runs on push tomainand on every PR.pyproject.tomldeclared the dependency asCADETProcess(the import name); the published distribution name isCADET-Process(hyphenated), and PEP 503 normalizes these to different names, so this dependency could never resolve — not in CI, not anywhere. Fixed toCADET-Process>=0.11.CADETProcess.instruments(the LC flow-sheet layer this GUI's whole architecture sits on) or the column/binding descriptorunit=/description=metadata (upstream PR #435) that several tests depend on. Both exist on CADET-Process'sdevbranch; pinned to its current commit (a064f9c) rather than floating on the branch tip, for reproducibility. This is a real, current constraint — CADET-GUI depends on not-yet-released CADET-Process features — and will need revisiting once CADET-Process cuts a release that includes them.playwrightto thetesting/devdependency groups and a Chromium install step:tests/test_element_views.py's headless-browser element tests were silently skipping everywhere (locally and would have in CI) for lack of a browser. They now actually run — 32+ tests that were never exercised.ruff.yml's push trigger listedmaster/dev(stale, inherited from a template); this repo's real branch ismain. Fixed both workflows to trigger on push tomain.Verified by building the exact environment
environment.yml+ these install steps produce, from scratch, in an isolated conda env: 588 passed, 0 failed, 0 skipped.Test plan
ruff checkclean