Repository navigation
Fence lifecycle replay and isolate CI fixtures (execution-connectors W12-β) - #694
Merged
rocketbitz merged 6 commits intoOct 23, 2026
Merged
Conversation
[Medium impact] The changes appear safe to merge; no new actionable issue was found. SummaryThe PR prevents repeated durable lifecycle events from starting duplicate downstream runs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Durable lifecycle publication can repeat when immediate completion overlaps the background dispatcher. The bridge previously assigned each copy a fresh ingested-event ID, allowing one source completion to launch two downstream runs. This change derives a stable internal ID from the trusted nonzero sequence and atomically stops routing when that ID already exists. Admission, match persistence and the replay fence share one transaction; rollback permits later delivery. Namespace guards and post-commit execution remain intact. The fence lasts while the ingested row is retained; legacy sequence-zero events and repeated external HTTP requests retain fresh-event behavior.
The real-surface regression starts a job over HTTP, holds its committed completion before immediate publication, observes background ingestion, then releases the same sequence. A terminal hook and a later unrelated HTTP-run completion establish that the bridge consumed the replay. It requires one ingested row, one match, one marketing run, empty queues and no finance delivery through ten configured dequeue intervals. The ordinary integration case retains its exact-one assertion and runs without a fault overlay or skip.
The qualification repairs also isolate generic HTTP fixtures, keep explicit cron/backfill schedules outside the live test window, and join owned work during child-test cleanup before deletion. This prevents the foreign cron work observed in the master SQL-budget failure; budgets are unchanged. Connector API probes close connections from their first request without retries. A controlled transport experiment supports that repair; the original hosted reset's cause remains an inference. The CLI-only group-refresh test gates its fake directory response until the initial assertion finishes, preserving its group and call-count assertions.
The mobile test sends its navigation chord in one
keyboard.type('gy')call. The failed trace bounds the actual keydown gap above 1,051.535ms against the existing one-second window; timer expiry remains an inference because the callback was not recorded. Controlled real input kept the drawer open after expired separate presses and navigated to/systemwith a valid batched chord. Product keyboard behavior, assertions, timeouts and retries are unchanged.The latest Helm shard 1 failure exposed a separate fixture premise: Docker Hub returned HTTP 500 while resolving
values_leaf'salpine:3.23. Caesium correctly bypassed cache reuse when immutable identity was unavailable, executed the task, and completed the run successfully. The fixture nevertheless required a cache hit. Its first-run checks established execution, not a usable image digest for every later tag lookup.The existing public-tag positive control now runs unchanged before DAG construction: two actual runs with
digestTTL: 0s, first execution and resolved digest, second cache hit with matching digest, and CLIwhyreportingCACHE_HIT. The graph's seven stable inputs use that observed digest inalpine:3.23@sha256:…references. The node-local mutable source and all transitive, skipped-predecessor and values-chain assertions remain. There are no added retries, skips, TTL windows or resolver fallbacks. The separate public-registry control still fails if its required lookup cannot succeed.Validation:
df1c2dba19e284851add9b389ab9fe7da53228f1, basecb77e8a3b53af20309b7b04ca24bcd463d63eccc, literal mergeeb1a930f77a1b7dd9d78f0b2d03b6027e815ba71, equal head/merge treeab1ea276cdbefe5456d6284b3a1f55715a73e3ad, new workflow, attempt 1, passed: 49 terminal jobs (46 successful and three expected release/nightly skips), all nine required checks successful. All six critical jobs finished 748 seconds afterchanges, within the 900-second budget.PASS once in 31.826s; distributedPASS once in 110.776s. Both drove real CLI/API execution against Kubernetes with zero skips or retries. Local executed tasks had claim attempt 0; distributed executed tasks had claim attempt 1. All 21 original assertions remain. Syntax and scoped whitespace checks plus all 188 CI-helper tests passed. Source stayed unchanged during both runs; owned resources were cleaned up.This PR changes fifteen files. F4 promotion and N1 remain unchecked; no PR result is counted as a qualifying master run. Required checks, whole-CI success and review requirements still govern merge readiness.