Skip to content

Buy/Sell flow (New UI) - #3365

Merged
malik1004x merged 55 commits into
devfrom
cw-1440-new-buy-sell-flow
Sep 11, 2026
Merged

Buy/Sell flow (New UI)#3365
malik1004x merged 55 commits into
devfrom
cw-1440-new-buy-sell-flow

Conversation

@malik1004x

@malik1004x malik1004x commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Issue Number (if Applicable): Fixes #

Description

Adds the new buy/sell flow consisting of several screens (amount selection, provider selection, payment method selection, confirmation and redirecting).
Also fixes several bugs in the viewmodel found during testing.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

@malik1004x malik1004x changed the title cw-1440-new-buy-sell-flow Buy/Sell flow (New UI) Jul 3, 2026
# Conflicts:
#	cw_core/lib/format_fixed.dart
#	cw_solana/lib/solana_client.dart
#	lib/cake_pay/src/widgets/rounded_overlay_cards_widget.dart
#	lib/di.dart
#	lib/new-ui/widgets/coins_page/assets_history/assets_history_section.dart
#	lib/new-ui/widgets/receive_page/receive_top_bar.dart
#	lib/solana/cw_solana.dart
#	lib/src/screens/buy/buy_sell_page.dart
#	lib/src/screens/connect_device/connect_device_page.dart
#	lib/view_model/buy/buy_sell_view_model.dart
#	lib/view_model/hardware_wallet/hardware_wallet_view_model.dart
#	lib/view_model/hardware_wallet/ledger_view_model.dart
#	lib/view_model/send/send_view_model.dart
# Conflicts:
#	lib/new-ui/widgets/coins_page/cards/cards_view.dart
#	lib/new-ui/widgets/receive_page/receive_top_bar.dart
Comment thread lib/entities/fiat_currency.dart Outdated
Comment thread lib/entities/fiat_currency.dart Outdated
Comment thread lib/src/screens/connect_device/connect_device_page.dart
Comment thread lib/solana/cw_solana.dart
Comment thread lib/new-ui/pages/buy_sell/buy_sell_confirmation_page.dart Outdated
Comment thread lib/new-ui/pages/buy_sell/buy_sell_provider_page.dart Outdated
Comment thread lib/new-ui/widgets/floating_amount_input.dart Outdated
Comment thread lib/new-ui/pages/buy_sell/buy_sell_amount_page.dart
Comment thread lib/new-ui/pages/buy_sell/buy_sell_amount_page.dart Outdated
malik1004x and others added 5 commits August 24, 2026 11:58
Co-authored-by: Konstantin Ullrich <konstantin@cakewallet.com>
Co-authored-by: Konstantin Ullrich <konstantin@cakewallet.com>

@Blazebrain Blazebrain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in addition to this, lets apply formatting to the new files as some seemed to not be properly formatted, along with a couple lint issues

Comment thread lib/new-ui/widgets/buy_sell/buy_sell_selector_modal.dart Outdated
Comment thread lib/new-ui/widgets/token_chain_display.dart
Comment thread lib/new-ui/pages/buy_sell/buy_sell_amount_page.dart Outdated
Comment thread lib/view_model/buy/buy_sell_view_model.dart
Comment thread lib/view_model/buy/buy_sell_view_model.dart
Comment thread lib/new-ui/pages/buy_sell/buy_sell_provider_page.dart Outdated
Comment thread lib/new-ui/pages/buy_sell/buy_sell_payment_method_page.dart Outdated
Comment thread lib/new-ui/pages/buy_sell/buy_sell_confirmation_page.dart Outdated
Comment thread lib/new-ui/pages/buy_sell/buy_sell_amount_page.dart Outdated
Comment thread lib/new-ui/widgets/floating_amount_input.dart
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

changes in dependencies

changed git refs:
  monero
    url   https://github.com/mrcyjanek/monero_c.git -> https://github.com/mrcyjanek/monero_c.git
    ref   cd4fe366cc8d3c188c91de279f43b29c0e044b15 -> 3bfb3856a838f2bf6b729501837bb0295dedf25d
    path  ./impls/monero.dart -> ./impls/monero.dart

@action
Future<void> changeFiatAmount({required String amount}) async {
fiatAmount = amount;
fiatAmount = amount.replaceAll(",", ".");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not a blocker, but let's try to standardize the use of .sanitized()

# Conflicts:
#	res/values/strings_it.arb
#	res/values/strings_ja.arb
#	res/values/strings_ko.arb
#	res/values/strings_my.arb
#	res/values/strings_nl.arb
#	res/values/strings_pl.arb
#	res/values/strings_pt.arb
#	res/values/strings_pt_BR.arb
#	res/values/strings_ru.arb
#	res/values/strings_th.arb
#	res/values/strings_tl.arb
#	res/values/strings_tr.arb
#	res/values/strings_uk.arb
#	res/values/strings_ur.arb
#	res/values/strings_vi.arb
#	res/values/strings_yo.arb
#	res/values/strings_zh.arb
@malik1004x
malik1004x merged commit bfae219 into dev Sep 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants