Feature/versioned recipes - #27
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bfefa0d76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| queryColumns = append(queryColumns, req.Sort.Column) | ||
| } | ||
| queryColumns = append(queryColumns, "__loom_row_id") | ||
| selectColumns := quotedColumns(queryColumns) + ", count() OVER() AS `__loom_total`" |
There was a problem hiding this comment.
When After is supplied and the page returns at least one row, the cursor predicate is appended to the same WHERE clause evaluated by count() OVER(). Consequently totalCount reports only rows remaining after the cursor and shrinks on every page, while an empty page unexpectedly uses r.count and reports the full filtered total. Compute the window count before applying the keyset predicate, as the previous nested query did, or issue the cursor-independent count separately.
Useful? React with 👍 / 👎.
|
|
||
| # These sentences are deliberately curated. The generator refuses to emit a row | ||
| # without one so a directory listing cannot masquerade as a semantic inventory. | ||
| RESPONSIBILITIES = { |
There was a problem hiding this comment.
This commit adds the cmd/loom-acceptance and internal/acceptance Go packages, but neither has an entry in this curated map. Running python3 scripts/package_audit.py therefore exits with responsibility map mismatch: missing=['cmd/loom-acceptance', 'internal/acceptance'], which also makes both generator-focused tests in scripts/tests/test_package_audit.py fail and prevents regeneration of the checked-in audit.
Useful? React with 👍 / 👎.
1 participant
No description provided.