Skip to content

Refactor error response references in API definition - #250

Open
bigludo7 wants to merge 1 commit into
mainfrom
fix246
Open

bigludo7 wants to merge 1 commit into
mainfrom
fix246

Conversation

@bigludo7

Copy link
Copy Markdown
Collaborator

Updated references to error responses in the call forwarding API definition to use centralized definitions from CAMARA_common.yaml.

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Use error from common schema

Which issue(s) this PR fixes:

Fixes #246

Special notes for reviewers:

Looking for advice from @tanjadegroot and/or @rartych

  • Use common error schema for 400, 401, 403 & 422
  • No use of Common for 404 & 429 to no introduce breaking change
  • Keep 501 as this API allows partial implementations

Changelog input

 release-note
- Use common error schema for 400, 401, 403 & 422

Additional documentation

This section can be blank.

docs

Updated references to error responses in the call forwarding API definition to use centralized definitions from CAMARA_common.yaml.
@camara-validation

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

@rartych

rartych commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Thanks @bigludo7
We need approval of another codeowner @chinaunicomyangfan - or I can recreate the PR.

@bigludo7

Copy link
Copy Markdown
Collaborator Author

Thanks @bigludo7 We need approval of another codeowner @chinaunicomyangfan - or I can recreate the PR.

Yes probably. You can copy/paste in a new PR and I will approve (Monday)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of new Commonalities common error types (through $ref)

2 participants