Skip to content

Align ClickToDial callback behavior with Commonalities r4.4 - #131

Merged
YadingFang merged 2 commits into
mainfrom
public-readiness/callback-alignment
Oct 23, 2026
Merged

YadingFang merged 2 commits into
mainfrom
public-readiness/callback-alignment

Conversation

@YadingFang

@YadingFang YadingFang commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • correction
  • documentation
  • tests

What this PR does / why we need it:

Close the remaining Commonalities r4.4 implicit-callback gaps before the Sync26 public release: accepted sink URLs were not returned, and callback security required Bearer authentication even though sinkCredential is optional.

Changes

  • Add optional Call.sink and echo accepted sinks in POST /calls (201) and GET /calls/{callId}; never return credential secrets.
  • Support HTTPS callbacks with or without Bearer authentication. The POST /calls OAuth requirements remain unchanged.
  • Add required callback responses 410 and 429 (Event Guide §3.5); retain the existing 2XX success response, including 204.
  • Extend Gherkin scenarios for authenticated/unauthenticated callbacks, no-sink creation, sink echo and secret non-disclosure.
  • Clarify callback security and accessTokenExpiresUtc relative to the call lifetime; refresh expired token-expiry examples.

Which issue(s) this PR fixes:

N/A

Special notes for reviewers:

The shared r4.4 AccessTokenCredential.accessTokenExpiresUtc description still uses explicit-subscription wording. CTD now documents the implicit call-lifetime rule locally without changing synced common schemas; whether this fully meets §3.4's attribute-level wording requirement may need upstream confirmation.

Changelog input

Align implicit callbacks with Commonalities r4.4: echo registered sinks, support optional callback authentication, add required 410/429 responses, and update tests and documentation.

@camara-validation

camara-validation Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

@YadingFang
YadingFang marked this pull request as ready for review October 23, 2026 03:03

@Wojiaozhenghao Wojiaozhenghao left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@YadingFang
YadingFang merged commit e74c8ae into main Oct 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants