Repository navigation
Align ClickToDial callback behavior with Commonalities r4.4 - #131
Merged
Merged
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 0 hints | Profile: standard |
YadingFang
marked this pull request as ready for review
October 23, 2026 03:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Close the remaining Commonalities r4.4 implicit-callback gaps before the Sync26 public release: accepted
sinkURLs were not returned, and callback security required Bearer authentication even thoughsinkCredentialis optional.Changes
Call.sinkand echo accepted sinks inPOST /calls(201) andGET /calls/{callId}; never return credential secrets.POST /callsOAuth requirements remain unchanged.410and429(Event Guide §3.5); retain the existing2XXsuccess response, including 204.accessTokenExpiresUtcrelative to the call lifetime; refresh expired token-expiry examples.Which issue(s) this PR fixes:
N/A
Special notes for reviewers:
The shared r4.4
AccessTokenCredential.accessTokenExpiresUtcdescription still uses explicit-subscription wording. CTD now documents the implicit call-lifetime rule locally without changing synced common schemas; whether this fully meets §3.4's attribute-level wording requirement may need upstream confirmation.Changelog input