Repository navigation
Conversation
… and Notification Guide (camaraproject#719) - Fix dangling TLS reference in 4.3: point to CAMARA API Design Guide 6.1 Good Practices for Securing REST APIs instead of non-existent 10.2 Security Implementation section. - Fix broken sink security-considerations link in 2.2.3 Subscriptions Data Model (43#... -> camaraproject#43-...). - Remove extra .api segment from subscription-ended example type value in 3.7 Notification Examples to match the mandated org.camaraproject.<api-name>.<event-version>.<event-name> pattern. - Quote numeric id values as strings in 3.7 Notification Examples to match the CloudEvent.id schema (type: string).
rartych
requested review from
PedroDiez,
bigludo7,
eric-murray and
jlurien
as code owners
October 12, 2026 13:27
eric-murray
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR fixes four editorial issues in the security-relevant parts of
CAMARA-API-Event-Subscription-and-Notification-Guide.md:sinkattribute's "security considerations" link was broken (43#notifications-security-considerations, a stray relative path) and now correctly resolves to#43-notifications-security-considerationswithin the same document.subscription-endedexample usedtype: "org.camaraproject.api.device-roaming-subscriptions.v1.subscription-ended", which includes an extra.apisegment that violates the mandatedorg.camaraproject.<api-name>.<event-version>.<event-name>pattern. The extra segment has been removed.idvalues (123654,123658), while theCloudEvent.idschema inCAMARA_event_common.yamldefinesidas astring. Both values are now quoted strings.Which issue(s) this PR fixes:
Fixes #719
Does this PR introduce a breaking change?
Special notes for reviewers:
Changelog input