Skip to content

Add per-operation test definitions for sample-service - #9

Open
hdamker wants to merge 1 commit into
camaraproject:mainfrom
hdamker:test/sample-service-test-definitions
Open

hdamker wants to merge 1 commit into
camaraproject:mainfrom
hdamker:test/sample-service-test-definitions

Conversation

@hdamker

@hdamker hdamker commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • tests

What this PR does / why we need it:

Adds one .feature file per operation of sample-service under code/Test_definitions/, adapted from the Commonalities r4.4 testing artifacts (sample-service-template.feature, C01-device-errors.feature). Each file covers the success path and the error responses documented for that operation in sample-service.yaml, and nothing beyond them.

  • Validation now runs the Gherkin engine on this repository; P-006 ("No .feature test file found") no longer fires.
  • The files give a concrete, lint-clean adaptation of the templates that can be contributed back to Commonalities.

Which issue(s) this PR fixes:

None.

Special notes for reviewers:

The adaptation already includes the changes proposed in camaraproject/Commonalities#727 (response header checks and their order) and camaraproject/Commonalities#732 (request body strictness, for createResource). For the invalid x-correlator scenarios the response x-correlator echo is not checked, pending the open question in camaraproject/Commonalities#726.

Changelog input

 release-note
Add per-operation test definitions for sample-service

Additional documentation

This section can be blank.

@hdamker
hdamker requested review from Kevsy and rartych as code owners October 23, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant