Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds one
.featurefile per operation ofsample-serviceundercode/Test_definitions/, adapted from the Commonalities r4.4 testing artifacts (sample-service-template.feature,C01-device-errors.feature). Each file covers the success path and the error responses documented for that operation insample-service.yaml, and nothing beyond them.Which issue(s) this PR fixes:
None.
Special notes for reviewers:
The adaptation already includes the changes proposed in camaraproject/Commonalities#727 (response header checks and their order) and camaraproject/Commonalities#732 (request body strictness, for
createResource). For the invalidx-correlatorscenarios the responsex-correlatorecho is not checked, pending the open question in camaraproject/Commonalities#726.Changelog input
Additional documentation
This section can be blank.