Repository navigation
Align Networks and Areas test definitions with the API definitions - #211
Open
jimfengjinhua wants to merge 1 commit into
Open
jimfengjinhua wants to merge 1 commit into
jimfengjinhua wants to merge 1 commit into
Conversation
Networks: - Expect REQUESTED as the initial network status in createNetwork - Add an INVALID_SINK scenario for createNetwork - Add read-after-create (readNetwork_02_success_created_network) and read-after-delete (readNetwork_404.03_deleted_network) scenarios - Set the resource and a compliant request body in the createNetwork 400 scenarios that modify a single request body property - Replace the ambiguous oneOf example row in createNetwork_400.05 with a row that removes both networkProfileId and qosProfileName Areas: - Expect INVALID_ARGUMENT for a latitude outside the schema range, sent as a number - Remove OUT_OF_RANGE from retrieveNetworkServiceAreas, as the API defines no condition for it Part of camaraproject#207 (the Accesses items are addressed separately)
jimfengjinhua
requested review from
PeterKovacs2,
carlosromerog,
eric-murray and
tlohmar
as code owners
October 23, 2026 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fixes the mismatches between the test definitions and the API definitions reported in #207 for the Networks and Areas APIs. The Accesses items (item 4) will follow in a separate PR, because of upcoming Accesses API changes (#205, #206).
Networks (
dedicated-network.feature)createNetwork_01andcreateNetwork_03now expectREQUESTEDonly, instead ofREQUESTEDorRESERVED. This matches the APIinfo.descriptionand the General Description, which both say a created network is alwaysREQUESTED.INVALID_SINK: newcreateNetwork_400.09_invalid_sink, aligned with the existingcreateAccess_400.09_invalid_sink.readNetwork_02_success_created_network: reads a network created bycreateNetworkand checksnetworkProfileId,serviceTimeandserviceAreaIdagainst the create requestreadNetwork_404.03_deleted_network: reads a network deleted bydeleteNetworkand expects404 NOT_FOUNDAreas (item 3)
retrieveNetworkServiceAreas_400.07_invalid_coordinates:INVALID_ARGUMENTinstead ofOUT_OF_RANGEContent-Type,$.statusand$.message, like the other 400 scenariosdedicated-network-areas.yaml):retrieveNetworkServiceAreasnow usesBadRequest400instead ofBadRequestWithRange400, soOUT_OF_RANGEis no longer declared.Also fixed (not in the issue)
createNetwork_400.04,400.05,400.07and400.08changed a request body property without first setting the resource and a compliant request body. They now do, like thecreateAccessequivalents. This is the same flaw item 4 reports for Accesses.createNetwork_400.05: the rowoneOf networkProfileId or qosProfileNamedid not say which property to remove. A compliant body contains exactly one of the two, so removing the absent one leaves a valid body, and a correct server would return201. The row now removes both$.networkProfileIdand$.qosProfileName, which always violates theoneOf.Which issue(s) this PR fixes:
Part of #207 (items 1, 2, 3 and 5; item 4 will be addressed separately)
Special notes for reviewers:
OUT_OF_RANGEis removed rather than defined:OUT_OF_RANGEas being for "a given field [that] has a pre-defined range or a invalid filter criteria combination". Its only concrete guidance (4.1.1, pagination) says values outside the allowed range MUST be rejected with400 INVALID_ARGUMENT.Latitude.maximum: 90in the schema, so it is a plain schema violation.OUT_OF_RANGE. There is no provider limit on radius or area size, and no filter combination is described as invalid. An error code that no documented condition can trigger can't be tested.OUT_OF_RANGEcan be added back together with its definition.Whenstep, followed by the status code (<operation>_<NN>_success_…or<operation>_<status>.<NN>_…). Both new scenarios sendreadNetwork, so they appear underreadNetwork, not undercreateNetworkordeleteNetwork.Givenstep and each scenario keeps a singleWhen. Comments on the phrasing are welcome.Changelog input
Additional documentation