Skip to content

Wrong credentialType value PRIVATE_JWT_KEY in subscription test definitions #149

Closed

Description

@hdamker

Problem description

The subscription feature files use PRIVATE_JWT_KEY as the sinkCredential.credentialType value. The value defined by the API (SinkCredential.credentialType, from Commonalities CAMARA_event_common.yaml) is PRIVATE_KEY_JWT. A conformant implementation rejects PRIVATE_JWT_KEY with 400 and never returns it, so these scenarios cannot pass. The typo comes from the Commonalities event-subscription test template, see camaraproject/Commonalities#728.

Expected action

Replace PRIVATE_JWT_KEY with PRIVATE_KEY_JWT, and private_jwt_key with private_key_jwt in scenario tags:

  • code/Test_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature: L195, L199, L207, L211, L219 (value); L194, L206, L467 (tags)
  • code/Test_definitions/device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscription.feature: L67, L68, L75 (value); L65 (tag)

Additional context

Line numbers refer to main at f3daedf. Also present in the published r2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions