Skip to content

[Fixed] Fix typo PRIVATE_JWT_KEY to PRIVATE_KEY_JWT in feature files #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-murray merged 4 commits into from
Oct 20, 2026
+14 −14
Merged

[Fixed] Fix typo PRIVATE_JWT_KEY to PRIVATE_KEY_JWT in feature files #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ddfca9
Fix typo PRIVATE_JWT_KEY to PRIVATE_KEY_JWT in scenarios
eric-murray Oct 20, 2026
e040aa3
Fix typo PRIVATE_JWT_KEY to PRIVATE_KEY_JWT in scenarios
eric-murray Oct 20, 2026
12caec9
Update scenario tag for device data volume subscription
eric-murray Oct 20, 2026
47d0f0d
Apply suggestion from @eric-murray
eric-murray Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...t_definitions/device-data-volume-subscriptions-createDeviceDataVolumeSubscription.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,32 +191,32 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation createDeviceData
And the response body property "$.sinkCredential.credentialType", if present, is set to value "ACCESSTOKEN"
And the response body property "$.sinkCredential.accessTokenExpiresUtc", if present, is set to the same value of the request property "$.sinkCredential.accessTokenExpiresUtc"

@device_data_volume_subscriptions_11_create_device_data_volume_subscription_sync_with_private_jwt_key_sink_credential_out_of_band_provisioning
Scenario: Create device data volume subscription (sync creation) with PRIVATE_JWT_KEY sinkCredential, out-of-band provisioning
@device_data_volume_subscriptions_12_create_device_data_volume_subscription_sync_with_private_key_jwt_sink_credential_out_of_band_provisioning
Scenario: Create device data volume subscription (sync creation) with PRIVATE_KEY_JWT sinkCredential, out-of-band provisioning
# Some implementations may only support asynchronous subscription creation
# Some implementations may only support out_of_band provisioning
Given that subscriptions are created synchronously
And the request property "$.sinkCredential.credentialType" is set to "PRIVATE_JWT_KEY"
And the request property "$.sinkCredential.credentialType" is set to "PRIVATE_KEY_JWT"
When the request "createDeviceDataVolumeSubscription" is sent
Then the response code is 201
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has the same value as the request header "x-correlator"
And the response body complies with the OAS schema at "#/components/schemas/Subscription"

@device_data_volume_subscriptions_12_create_device_data_volume_subscription_sync_with_private_jwt_key_sink_credential_in_band_provisioning
Scenario: Create device data volume subscription (sync creation) with PRIVATE_JWT_KEY sinkCredential, in-band provisioning
@device_data_volume_subscriptions_13_create_device_data_volume_subscription_sync_with_private_key_jwt_sink_credential_in_band_provisioning
Scenario: Create device data volume subscription (sync creation) with PRIVATE_KEY_JWT sinkCredential, in-band provisioning
# Some implementations may only support asynchronous subscription creation
# Some implementations may additionally support in_band provisioning
Given that subscriptions are created synchronously
And the request property "$.sinkCredential.credentialType" is set to "PRIVATE_JWT_KEY"
And the request property "$.sinkCredential.credentialType" is set to "PRIVATE_KEY_JWT"
And the request property "$.sinkCredential.clientId" is set to a valid value
And the request property "$.sinkCredential.tokenUri" is set to a valid value
When the request "createDeviceDataVolumeSubscription" is sent
Then the response code is 201
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has the same value as the request header "x-correlator"
And the response body complies with the OAS schema at "#/components/schemas/Subscription"
And the response body property "$.sinkCredential.credentialType" is set to value "PRIVATE_JWT_KEY"
And the response body property "$.sinkCredential.credentialType" is set to value "PRIVATE_KEY_JWT"
And the response body property "$.sinkCredential.jwksUri" is set to a valid value

##########################################################
Expand Down Expand Up @@ -464,10 +464,10 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation createDeviceData
And the response property "$.code" is "MULTIEVENT_SUBSCRIPTION_NOT_SUPPORTED"
And the response property "$.message" contains a user friendly text

@device_data_volume_subscriptions_422.02_creation_with_private_jwt_key_not_configured
@device_data_volume_subscriptions_422.02_creation_with_private_key_jwt_not_configured
Scenario: Private JWT Key not configured for subscription creation
Given the API provider requires the use of a Private JWT key mechanism for subscription creation authentication
And the Private JWT key mechanism is not pre-configured in the environment
Given the API provider requires the use of a private key JWT mechanism for subscription creation authentication
And the private key JWT mechanism is not pre-configured in the environment
And a valid subscription request body with the property "$.sinkCredential.credentialType" set to "PRIVATE_KEY_JWT"
When the request "createDeviceDataVolumeSubscription" is sent
Then the response code is 422
Expand Down
8 changes: 4 additions & 4 deletions ...definitions/device-data-volume-subscriptions-retrieveDeviceDataVolumeSubscription.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,17 @@ Feature: Device Data Volume Subscriptions API, vwip - Operation retrieveDeviceDa
And the response body property "$.sinkCredential.credentialType", if present, is set to value "ACCESSTOKEN"
And the response body property "$.sinkCredential.accessTokenExpiresUtc", if present, is set to the same value of the request property "$.sinkCredential.accessTokenExpiresUtc"

@device_data_volume_subscriptions_04_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_private_jwt_key_sink_credential_returned
@device_data_volume_subscriptions_04_Operation_to_retrieve_subscription_based_on_an_existing_subscription-id_private_key_jwt_sink_credential_returned
# Some implementations may decide to not return the sinkCredential in the response (data minimization principle)
# Mainly applicable for in-band provisioning of PRIVATE_JWT_KEY mode for a given subscription
Scenario: Get a subscription based on existing subscription-id, with PRIVATE_JWT_KEY sinkCredential returned.
# Mainly applicable for in-band provisioning of PRIVATE_KEY_JWT mode for a given subscription
Scenario: Get a subscription based on existing subscription-id, with PRIVATE_KEY_JWT sinkCredential returned.
Given the path parameter "subscriptionId" is set to the identifier of an existing roaming status subscription
When the request "retrieveDeviceDataVolumeSubscription" is sent
Then the response code is 200
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has the same value as the request header "x-correlator"
And the response body complies with the OAS schema at "#/components/schemas/Subscription"
And the response body property "$.sinkCredential.credentialType" is set to value "PRIVATE_JWT_KEY"
And the response body property "$.sinkCredential.credentialType" is set to value "PRIVATE_KEY_JWT"
And the response body property "$.sinkCredential.jwksUri" is set to a valid value

##################
Expand Down
Loading