Skip to content

Align with Commonalities r4.4 - #54

Merged
maheshc01 merged 1 commit into
mainfrom
fix/align-commonalities-r4.4
Oct 22, 2026
Merged

maheshc01 merged 1 commit into
mainfrom
fix/align-commonalities-r4.4

Conversation

@maheshc01

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • correction
  • tests

What this PR does / why we need it:

Aligns the API with Commonalities r4.4 for the r1.2 release candidate, following the code/common sync in #52.

  • 400, 401, 403, 404 and 422 now reference the r4.4 catalogue responses (BadRequest400, Unauthenticated401, PermissionDenied403, IdentifierNotFound404, DeviceIdentifier422), which carry exactly the codes this API declared before
  • 429 is defined locally with QUOTA_EXCEEDED and TOO_MANY_REQUESTS, referencing the shared r4.4 examples
  • Updated the "Additional CAMARA error responses" section from the r4.4 template
  • Added 429 test scenarios for TOO_MANY_REQUESTS and QUOTA_EXCEEDED, as agreed in Address r1.1 review findings in the API definition and test definitions #47
  • 422 scenarios now say "user-friendly", as in the Commonalities C01 template

Which issue(s) this PR fixes:

Related to #37 (r1.1 review issues) and #40 (429 errors).

Special notes for reviewers:

No change to the declared error codes or to the API behaviour. Next step after merge is the r1.2 snapshot (#53).

Changelog input

 release-note
Aligned with Commonalities r4.4 error responses and templates; added 429 test scenarios

Additional documentation

docs

- Use r4.4 catalogue responses for 400/401/403/404/422, local 429
- Update mandatory description text from r4.4 templates
- Add 429 test scenarios for TOO_MANY_REQUESTS and QUOTA_EXCEEDED
- Use 'user-friendly' wording in 422 scenarios as in the C01 template
@camara-validation

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

@maheshc01

Copy link
Copy Markdown
Contributor Author

@Kevsy and @sachinvodafone requesting your review

@maheshc01

Copy link
Copy Markdown
Contributor Author

@Kevsy and @sachinvodafone requesting for your review

@Kevsy Kevsy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maheshc01
maheshc01 merged commit ad6811f into main Oct 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants