Repository navigation
Align number recycling with Commonalities r4.4 in terms of testing - #130
Conversation
|
@eric-murray, @grgpapadopoulos, would you review this PR? |
| Scenario: Invalid Argument. Generic Syntax Exception | ||
| Given the request body is set to any value which is not compliant with the OAS schema at "/components/schemas/CreateCheckNumRecycling" | ||
| When the HTTP "POST" request is sent | ||
| @checkNumberRecycling_400.05_invalid_specifiedDate |
There was a problem hiding this comment.
This is a Scenario, not a Scenario Outline, and has no Examples, so <invalid_specifiedDate> is never substituted. Either use a literal invalid value or convert it to an Outline with Examples.
There was a problem hiding this comment.
Thank you for pointing out. I have updated it with literal explanation.
albertoramosmonagas
left a comment
There was a problem hiding this comment.
Template scenarios that apply are missing: 400.05_missing_required_property (specifiedDate is required) and 400.06_invalid_x-correlator. In the template, 400.04 and 400.05 are different scenarios (empty_property, missing_required_property). The PR reuses those numbers for its own cases (out_of_range, invalid_specifiedDate). Please renumber the custom cases after the generic ones, or give them a different convention.
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
|
@albertoramosmonagas, thank for pointing out. I have tried to resolve it. Please check it. |
albertoramosmonagas
left a comment
There was a problem hiding this comment.
LGTM with te new changes
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
What type of PR is this?
What this PR does / why we need it:
To Align number recycling with Commonalities r4.4 in terms of testing
Which issue(s) this PR fixes:
Fixes #126
Special notes for reviewers:
Updates are based on the following three points:
operationIdin request sending descriptionChangelog input
Additional documentation
None