Skip to content

Align number recycling with Commonalities r4.4 in terms of testing - #130

Merged
Masa8106 merged 13 commits into
camaraproject:mainfrom
Masa8106:Masa8106-Align-Test-CommR4.4-rc2
Oct 26, 2026
Merged

Masa8106 merged 13 commits into
camaraproject:mainfrom
Masa8106:Masa8106-Align-Test-CommR4.4-rc2

Conversation

@Masa8106

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • correction

What this PR does / why we need it:

To Align number recycling with Commonalities r4.4 in terms of testing

Which issue(s) this PR fixes:

Fixes #126

Special notes for reviewers:

Updates are based on the following three points:

  • Using operationId in request sending description
  • Aligning with sample-service-template.feature
  • Aligning with C02-phoneNumber-errors.feature

Changelog input

 release-note
  -To Align number recycling with Commonalities r4.4 in terms of testing

Additional documentation

None

@Masa8106

Copy link
Copy Markdown
Contributor Author

@eric-murray, @grgpapadopoulos, would you review this PR?

Comment thread code/Test_definitions/number-recycling.feature Outdated
Comment thread code/Test_definitions/number-recycling.feature Outdated
Comment thread code/Test_definitions/number-recycling.feature Outdated
Comment thread code/Test_definitions/number-recycling.feature Outdated
Scenario: Invalid Argument. Generic Syntax Exception
Given the request body is set to any value which is not compliant with the OAS schema at "/components/schemas/CreateCheckNumRecycling"
When the HTTP "POST" request is sent
@checkNumberRecycling_400.05_invalid_specifiedDate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Scenario, not a Scenario Outline, and has no Examples, so <invalid_specifiedDate> is never substituted. Either use a literal invalid value or convert it to an Outline with Examples.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing out. I have updated it with literal explanation.

Comment thread code/Test_definitions/number-recycling.feature Outdated
Comment thread code/Test_definitions/number-recycling.feature Outdated
Comment thread code/Test_definitions/number-recycling.feature Outdated

@albertoramosmonagas albertoramosmonagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template scenarios that apply are missing: 400.05_missing_required_property (specifiedDate is required) and 400.06_invalid_x-correlator. In the template, 400.04 and 400.05 are different scenarios (empty_property, missing_required_property). The PR reuses those numbers for its own cases (out_of_range, invalid_specifiedDate). Please renumber the custom cases after the generic ones, or give them a different convention.

Masa8106 and others added 9 commits October 21, 2026 09:15
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
@Masa8106

Copy link
Copy Markdown
Contributor Author

@albertoramosmonagas, thank for pointing out. I have tried to resolve it. Please check it.

Comment thread code/Test_definitions/number-recycling.feature Outdated
Comment thread code/Test_definitions/number-recycling.feature Outdated

@albertoramosmonagas albertoramosmonagas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with te new changes

Masa8106 and others added 2 commits October 21, 2026 10:22
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
Co-authored-by: Alberto Ramos Monagas <alberto.ramosmonagas@telefonica.com>
@Masa8106
Masa8106 merged commit e6229dd into camaraproject:main Oct 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align number recycling with Commonalities r4.4

4 participants