Repository navigation
fix: remove 410 sink gone scenario from test definitions - #168
Merged
jgarciahospital merged 1 commit intoOct 20, 2026
Merged
Conversation
The 410 SinkGone response is returned by the API consumer in the callback, so it does not belong in the API provider test file. Fixes camaraproject#167
albertoramosmonagas
requested review from
jgarciahospital,
maheshc01 and
sachinvodafone
as code owners
October 20, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Removes the
population_density_data_12_async_sink_gone_scenariotest case (callback sink answering with 410) fromcode/Test_definitions/population-density-data.feature.The 410
SinkGone410status is returned by the API consumer in the callback, so it must not be tested on the API provider side. The scenario was added after a review comment that mistakenly requested it.The PR also removes the header lines that only existed for that scenario (the callback endpoint testing asset and the retry-policy wait time). It also updates the reference "scenarios 07, 08, 11 and 12" to "07, 08 and 11".
Which issue(s) this PR fixes:
Fixes #167
Special notes for reviewers:
.featurefile changes. As suggested in the issue, this fix should not be listed in the final changelog.