Repository navigation
Release Review: SubscriptionStatus r2.1 (rc Sync26) - #37
chinaunicomyangfan merged 4 commits into
Conversation
CAMARA Validation — PASS0 errors, 0 warnings, 0 hints | Profile: standard |
eric-murray
left a comment
There was a problem hiding this comment.
Initial review findings documented in #38.
Nothing major and nothing that would prevent this release as is.
However, you need to update the change log by editing the CHANGELOG-r2.md file in this PR and including relevant changes each section of the template. Review other KYC APIs for guidance on what is expected.
|
Thank you, @eric-murray , for the review. Hi @chinaunicomyangfan , @ClownsAlbert , @ChuanyuChen , @DanXu-ChinaTelecom , Please do Update the CHANGELOG to proceed with the release of a RC. Thanks, |
|
FYI: This snapshot was created before camaraproject/tooling#431 got active with tooling release v0.10.0. #431 moved the automated README Release Information update from the release-review branch onto the snapshot branch. The merge commit above brings this branch in line with that: the README update now lives on the snapshot branch, so this branch differs from it by the CHANGELOG only. No content change. |
Team, please also consider addressing Eric's comments in #38 on main and do a new snapshot for this release. Thanks ! Please also ensure to follow and tick off accordingly the code-owners checklist in the Release Review issue. After this release-candidiate is published, you can do the next rc for Commonalities r4.4 alignment (this requires updating the release-plan before doing the new snapshot. |
Hi @tanjadegroot , Thank you for the guidance. Just to ensure we are perfectly aligned on the next steps, could you please confirm which of the following workflows you intended? Workflow A:
OR Workflow B:
Your clarification would be greatly appreciated. Thanks! |
|
It is up to the API team, but I would recommend Workflow B so that the M3 requirement is satisfied for this API. If you tag me when the change log is updated, I will approve this PR. |
|
@ToshiWakayama-KDDI will you do the changelog update so we can proceed to M3 please ? Let me know if you need any help. |
|
|
||
| ### Changed | ||
|
|
||
| * N/A |
There was a problem hiding this comment.
Just to add a PR #36 here is enough, I believe:
- Align subscription-status with Sync26 RC requirements by @chinaunicomyangfan in Align subscription-status with Sync26 RC requirements #36
Thanks, @tanjadegroot . I have just tried, but it seems I can't do it because I have no wirte access to this API. I have jsut left a comment to the line where text about PR #36 should be added, and I believe this is only the change needed. I will send an email to @chinaunicomyangfan for heads-up. BR |
|
@ToshiWakayama-KDDI Thanks for flagging this! The CHANGELOG has been updated, ready for re-review. |
|
@eric-murray CHANGELOG has been updated, ready for re-review. Thanks! |
|
Thanks, @chinaunicomyangfan . Please don't forget to tick the above three points ( Update the CHANGELOG, Document deferred validation warnings (and hints), The release is ready for Release Management review ) to show you have confirmed them. BR |
eric-murray
left a comment
There was a problem hiding this comment.
Approving release candidate for publication on behalf of Release Management
|
Hi team, please check and tick the "Codeowner Actions" to complete the review process and proceed to merge. many thanks ! |
|
Hi team, please proceed to M3 by
After that please address on main
And then snapshot r2.2; update the changelog; check and tick the "Codeowner action" boxes. Many thanks ! |
adbd87a
into
release-snapshot/r2.1-9adaaa9
@ToshiWakayama-KDDI Thanks for the reminder! The three checkboxes have been ticked. Validation shows 0 errors/warnings/hints, so no deferred items to document. |
Release Review: r2.1 rc
This PR finalizes the reviewable release content for the active snapshot.
Edit and review this PR before merging it into the release snapshot. After Codeowner and Release Management approval, merging this PR creates the draft release.
Release contents
0.2.0-rc.10.1.0Dependencies: Commonalities r4.3, ICM r4.2
Codeowner Actions
Tick each box once done. Ticking the last box — "The release is ready for Release Management review" — starts the Release Management review.
Update the CHANGELOG
What to do:
Document deferred validation warnings (and hints)
What to do:
The release is ready for Release Management review
Check that:
Tick this box to confirm readiness and to start the Release Management review.
Release Management Actions
The following actions and checks are done by a Release Management reviewer before approving the PR:
Required release assets per API status
public
public
M = Mandatory, O = Optional — Full documentation
Valid next actions for codeowners
/discard-snapshot <reason>in the Release Issue to discard this snapshot, return toplanned, and update content onmainSnapshot:
r2.1-9adaaa9