Skip to content

ISSUE-235 - Test scenarios review and aligment with Commonalities r4.4 - #243

Merged
stroncoso merged 2 commits into
camaraproject:mainfrom
stroncoso:stroncoso/issue235-test-scenarios
Oct 15, 2026
Merged

stroncoso merged 2 commits into
camaraproject:mainfrom
stroncoso:stroncoso/issue235-test-scenarios

Conversation

@stroncoso

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • tests

What this PR does / why we need it:

Aligns all WebRTC feature files with the API definitions and the Commonalities r4.4 test templates (sample-service-template, event-subscription-template, C02-phoneNumber-errors):

  • Corrects existing scenarios that could not pass against a compliant implementation (removed clientCorrelator, missing status body in updateSessionStatus, wrong paths in path-parameter scenarios, past subscriptionExpireTime, wrong response schemas).
  • Declares the token-type assumption in each feature context; createRegistration covers both 3-legged and 2-legged (phoneNumber) flows.
  • Adds scenarios for every error response declared in the API definitions.

Which issue(s) this PR fixes:

Fixes #235
Fixes #229

Special notes for reviewers:

  • Removed scenarios that cannot be executed against the spec: deviceId-based 422 MISSING_IDENTIFIER / UNSUPPORTED_IDENTIFIER / UNNECESSARY_IDENTIFIER and 403 SUBSCRIPTION_MISMATCH (deviceId is required and client-generated, never derived from the token), and the unknown-property 400 (additionalProperties is not false).
  • Event-subscription template scenarios for subscriptionMaxEvents, initialEvent, PRIVATE_KEY_JWT and pagination are not included, as the API does not support them.
  • Spec issue found, not addressed here: Subscription.types has maxItems: 1 while SubscriptionRequest.types allows 3, so multi-event responses cannot comply.

The Subscription.types limit still needs a fix in the API YAML. It will be reviewed on a separated issue.

Changelog input

 release-note
task(tests): align test scenarios with API definitions and Commonalities templates

Additional documentation

n/a

@deepakjaiswal1 deepakjaiswal1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stroncoso

Copy link
Copy Markdown
Contributor Author

Thanks Deepak! Merging and keeping going on! 🙌

@stroncoso
stroncoso merged commit 39ca020 into camaraproject:main Oct 15, 2026
2 checks passed
@stroncoso
stroncoso deleted the stroncoso/issue235-test-scenarios branch October 16, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct existing test scenarios that don't match the API definitions Error cases specified in yaml not covered by test case(s)

2 participants