Repository navigation
ISSUE-235 - Test scenarios review and aligment with Commonalities r4.4 - #243
Merged
stroncoso merged 2 commits intoOct 15, 2026
Merged
Conversation
stroncoso
requested review from
deepakjaiswal1,
pradeepachar-mavenir and
teikuran
as code owners
October 14, 2026 20:14
Contributor
Author
|
Thanks Deepak! Merging and keeping going on! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Aligns all WebRTC feature files with the API definitions and the Commonalities r4.4 test templates (
sample-service-template,event-subscription-template,C02-phoneNumber-errors):clientCorrelator, missingstatusbody inupdateSessionStatus, wrong paths in path-parameter scenarios, pastsubscriptionExpireTime, wrong response schemas).createRegistrationcovers both 3-legged and 2-legged (phoneNumber) flows.Which issue(s) this PR fixes:
Fixes #235
Fixes #229
Special notes for reviewers:
MISSING_IDENTIFIER/UNSUPPORTED_IDENTIFIER/UNNECESSARY_IDENTIFIERand 403SUBSCRIPTION_MISMATCH(deviceId is required and client-generated, never derived from the token), and the unknown-property 400 (additionalPropertiesis notfalse).subscriptionMaxEvents,initialEvent, PRIVATE_KEY_JWT and pagination are not included, as the API does not support them.Subscription.typeshasmaxItems: 1whileSubscriptionRequest.typesallows 3, so multi-event responses cannot comply.The Subscription.types limit still needs a fix in the API YAML. It will be reviewed on a separated issue.
Changelog input
Additional documentation
n/a