Repository navigation
fix(ra): treat a missing ref as absent when deleting a branch - #490
Merged
hdamker merged 1 commit intoOct 23, 2026
Conversation
GitHub answers a DELETE on a nonexistent ref with 422 "Reference does not exist", not 404. The first discard of a snapshot id therefore failed to rename the review branch to -preserved.
hdamker
merged commit Oct 23, 2026
a37b33e
into
camaraproject:release-automation-refactor
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / why we need it:
GitHubClient.delete_branchtreated only 404 / "not found" as a missing branch. GitHub answers a DELETE on a nonexistent ref with HTTP 422 "Reference does not exist", so the call raised.preserve_review_branchdeletes<review>-preservedfirst to replace an older copy; for a snapshot id that was never discarded before, that raised, the rename was skipped (Could not rename review branch) and/discard-snapshotstill reported success. The branch canary on ReleaseTest2 failed at "verify post-discard" for this reason; the earlier green run only passed because a-preservedbranch already existed.delete_branchnow returnsFalsefor that response and still raises on other errors.Which issue(s) this PR fixes:
Part of #476
Special notes for reviewers:
Targets
release-automation-refactor. The same call is used when deleting the snapshot and review branches in the publish path.Changelog input
Additional documentation