Skip to content

ci(tooling): make ShellCheck blocking in actionlint and fix the two validation.yml findings #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hdamker merged 1 commit into from
Oct 24, 2026
Merged

ci(tooling): make ShellCheck blocking in actionlint and fix the two validation.yml findings #493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/tooling-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ jobs:
)

actionlint_args=(
-shellcheck=
-pyflakes=
-ignore 'missing input "app-id" which is required by action "actions/create-github-app-token@v3"'
-ignore 'input "client-id" is not defined in action "actions/create-github-app-token@v3"'
Expand Down Expand Up @@ -174,12 +173,12 @@ jobs:
echo "| Check | Result | Artifact |"
echo "| --- | --- | --- |"
if [[ "$status" -eq 0 ]]; then
echo "| Core workflow semantics | pass | tooling-ci-actionlint-json: artifacts/actionlint/actionlint.json |"
echo "| Workflow semantics and ShellCheck | pass | tooling-ci-actionlint-json: artifacts/actionlint/actionlint.json |"
else
echo "| Core workflow semantics | fail | tooling-ci-actionlint-json: artifacts/actionlint/actionlint.json |"
echo "| Workflow semantics and ShellCheck | fail | tooling-ci-actionlint-json: artifacts/actionlint/actionlint.json |"
fi
echo
echo "ShellCheck and pyflakes integrations are disabled for the first rollout; the current blocking check is core actionlint semantics."
echo "ShellCheck is blocking; the pyflakes integration stays disabled."
} >> "$GITHUB_STEP_SUMMARY"

exit "$status"
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,7 @@ jobs:
name=$(basename "$spec")
# Skip specs with no external $ref — bundling would only
# normalize formatting, producing a misleading diff artifact.
# shellcheck disable=SC2016 # \$ref is a regex, not an expansion
if ! grep -qE '\$ref:\s*["'"'"'][^#]' "$spec"; then
echo "Skipped (no external \$ref): $name"
continue
Expand Down Expand Up @@ -585,8 +586,10 @@ jobs:
- name: Report orchestrator failure
if: always() && steps.validation.outcome == 'failure'
run: |
echo "## CAMARA Validation" >> "$GITHUB_STEP_SUMMARY"
echo "" >> "$GITHUB_STEP_SUMMARY"
echo "**Error**: The validation orchestrator failed with an infrastructure error." >> "$GITHUB_STEP_SUMMARY"
echo "Check the workflow logs for details." >> "$GITHUB_STEP_SUMMARY"
{
echo "## CAMARA Validation"
echo ""
echo "**Error**: The validation orchestrator failed with an infrastructure error."
echo "Check the workflow logs for details."
} >> "$GITHUB_STEP_SUMMARY"
exit 1
Loading