Repository navigation
Add size-based HAProxy log rotation with hourly checks - #673
Merged
Merged
Conversation
Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix lack of logrotate configuration to prevent disk exhaustion
Add size-based HAProxy log rotation with hourly checks
Oct 6, 2026
Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
Thanhphan1147
marked this pull request as ready for review
October 7, 2026 18:45
Collaborator
|
[merge bot]: This PR is now being monitored to automatically rerun failing tests |
Thanhphan1147
enabled auto-merge (squash)
October 7, 2026 18:47
swetha1654
approved these changes
Oct 8, 2026
javierdelapuente
approved these changes
Oct 8, 2026
Copilot stopped work on behalf of
Thanhphan1147 due to an error
October 8, 2026 11:59
Collaborator
|
@copilot add logrotate to .custom_wordlist |
Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
Contributor
Author
Added |
Co-authored-by: Thanhphan1147 <42444001+Thanhphan1147@users.noreply.github.com>
Thanhphan1147
enabled auto-merge (squash)
October 8, 2026 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
maxsize 1Gwhile preserving daily rotation, seven retained logs, compression, and the rsyslog reopen hook.Why we need it
High-traffic ingresses can exhaust disk space before time-based rotation runs, causing unit errors and service disruption. Size-triggered rotation with hourly checks reduces that risk without adding charm configuration options.
Checklist
docs/changelog.mdwith user-relevant changesdocs/release-notes/artifacts. If no change artifact is necessary, I tagged the PR with the labelno-release-note.(e.g., in
.github/workflows/integration_tests.yaml, ensure themoduleslist is correct)terraform fmtpasses andtflintreports no errorsTest plan
354 unit tests passed. Isolated logrotate checks covered repeated same-day size rotation, daily behavior, compression, and retention. Lint, Bandit, CodeQL, and secret scans passed.
Review focus
1Gis a rotation threshold, not a hard cap: logs can grow beyond it between checks.