Skip to content

internal: Write only changed heartbeat columns - #836

Open
jrtorsella wants to merge 1 commit into
canonical:v4from
jrtorsella:LXD-5253
Open

jrtorsella wants to merge 1 commit into
canonical:v4from
jrtorsella:LXD-5253

Conversation

@jrtorsella

Copy link
Copy Markdown
Contributor

@roosterfish roosterfish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good already, only a few comments.

Comment thread internal/cluster/cluster_members_test.go Outdated
Comment thread internal/cluster/cluster_members_test.go
Comment thread internal/rest/resources/heartbeat.go
Signed-off-by: Joseph Robert Torsella <joey.torsella@canonical.com>

@roosterfish roosterfish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, is this ready to go? Likely we should also backport to v3.

@jrtorsella

Copy link
Copy Markdown
Contributor Author

Thanks, is this ready to go? Likely we should also backport to v3.

Let me take a look and make sure when I get to my desk this morning. I'll mark as out of draft if so. Yeah, agreed.

@jrtorsella
jrtorsella marked this pull request as ready for review October 14, 2026 12:15
@jrtorsella

jrtorsella commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks, is this ready to go? Likely we should also backport to v3.

yep, this is ready. Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Each heartbeat round rewrites every column of every member, producing at least 2x more raft log than is necessary

2 participants