Repository navigation
API: Add authorization hook - #840
Merged
Merged
Conversation
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
…r mTLS check Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
0 open findings
What changed in this PR
Adds a configurable authentication hook that can replace default mTLS validation for API requests.
Changes:
- Defines the public
Hooks.OnAuthenticateAPI. - Integrates the hook into HTTP request authentication.
| File | Summary |
|---|---|
microcluster/types/hooks.go |
Defines the public authentication hook API. |
internal/rest/access/authentication.go |
Integrates the hook into request authentication. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
roosterfish
marked this pull request as ready for review
October 16, 2026 09:49
tugbataluy
approved these changes
Oct 16, 2026
markylaing
added a commit
that referenced
this pull request
Oct 16, 2026
markylaing
added a commit
that referenced
this pull request
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.