Skip to content

feat(rating): Cloudkitty initial - #581

Open
mv-2112 wants to merge 1 commit into
canonical:mainfrom
mv-2112:Cloudkitty-initial
Open

feat(rating): Cloudkitty initial#581
mv-2112 wants to merge 1 commit into
canonical:mainfrom
mv-2112:Cloudkitty-initial

Conversation

@mv-2112

@mv-2112 mv-2112 commented Sep 13, 2025

Copy link
Copy Markdown

Initial commit to provide the cloudkitty rating service to sunbeam

gboutry
gboutry requested changes Sep 15, 2025
View reviewed changes

@gboutry gboutry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Let's make sure to wait for cloudkitty-k8s to be available on the 2024.1 and to 2025.1 channels, to have the changes landed in the plan.

Comment thread sunbeam-python/sunbeam/features/rating/feature.py
Comment thread sunbeam-python/sunbeam/features/rating/feature.py Outdated
@mv-2112

mv-2112 commented Sep 15, 2025

Copy link
Copy Markdown
Author

Thank you.

Let's make sure to wait for cloudkitty-k8s to be available on the 2024.1 and to 2025.1 channels, to have the changes landed in the plan.

Will drop this into draft once it runs through.

@mv-2112
mv-2112 marked this pull request as draft September 15, 2025 18:52
@mv-2112
mv-2112 marked this pull request as ready for review September 17, 2025 21:20
@hemanthnakkina

hemanthnakkina commented Sep 18, 2025

Copy link
Copy Markdown
Collaborator

Depends-On: canonical/sunbeam-terraform#117

@mv-2112
mv-2112 requested a review from gboutry September 22, 2025 16:50
@mv-2112
mv-2112 marked this pull request as draft October 17, 2025 08:38
@mv-2112
mv-2112 marked this pull request as ready for review October 22, 2025 19:16
@mv-2112

mv-2112 commented Oct 22, 2025

Copy link
Copy Markdown
Author

Anything further to do here?

@mv-2112 mv-2112 mentioned this pull request Oct 23, 2025
Closed
@mv-2112

mv-2112 commented Oct 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Related to: canonical/canonical-openstack-docs#120 canonical/canonical-openstack-docs#244

@mv-2112
mv-2112 force-pushed the Cloudkitty-initial branch from 9fa6590 to 7bed4c4 Compare October 23, 2025 13:58
@mv-2112
mv-2112 marked this pull request as draft February 23, 2026 11:25
@mv-2112
mv-2112 marked this pull request as draft February 23, 2026 11:25
@mv-2112 mv-2112 changed the title Cloudkitty initial [WIP] Cloudkitty initial Feb 23, 2026
@mv-2112 mv-2112 changed the title [WIP] Cloudkitty initial feat(rating): Cloudkitty initial Aug 28, 2026
@mv-2112
mv-2112 marked this pull request as ready for review August 28, 2026 15:49
@hmlanigan

hmlanigan commented Aug 31, 2026

Copy link
Copy Markdown

cloudkitty-k8s charm has versions in latest, 2026.1 and 2025.1 edge channels. There is not a track for 2024.1.

@gboutry what is the plan for this feature?

@mv-2112

mv-2112 commented Sep 4, 2026

Copy link
Copy Markdown
Author

Also need to understand how to move this behind a feature gate if necessary?

@hemanthnakkina

hemanthnakkina commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

cloudkitty-k8s charm has versions in latest, 2026.1 and 2025.1 edge channels. There is not a track for 2024.1.

@gboutry what is the plan for this feature?

I think we should support cloudkitty on Gazpacho unless someone needs it on Caracal

hemanthnakkina
hemanthnakkina requested changes Sep 7, 2026
View reviewed changes

@hemanthnakkina hemanthnakkina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise LGTM

Comment thread sunbeam-python/sunbeam/features/rating/feature.py
Comment thread sunbeam-python/sunbeam/features/rating/README.md Outdated
@hemanthnakkina
hemanthnakkina self-requested a review September 7, 2026 08:26
hemanthnakkina
hemanthnakkina previously approved these changes Sep 7, 2026
View reviewed changes
@hemanthnakkina

hemanthnakkina commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

@mv-2112 Can you squash your commits into a single commit.

@mv-2112

mv-2112 commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@mv-2112 Can you squash your commits into a single commit.

Done.

gboutry
gboutry requested changes Sep 10, 2026
View reviewed changes

@gboutry gboutry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reword the commit to:

feat: implement rating feature

Implement initial rating feature deploying
upstream project CloudKitty.

(or don't hesitate to add more in the body)

Comment thread sunbeam-python/sunbeam/features/rating/feature.py Outdated

class RatingFeature(OpenStackControlPlaneFeature):
version = Version("0.0.1")
requires = {FeatureRequirement("telemetry")}

@gboutry gboutry Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that we implemented CloudKitty to depend on Loki, and Loki is deployed by the observability feature.

So, as far as I'm aware, We need both telemetry and observability features enabled?

@mv-2112 mv-2112 Sep 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add using CaaS as an example for multiple features.

@mv-2112 mv-2112 Sep 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. (And squashed)

@mv-2112 mv-2112 mentioned this pull request Sep 11, 2026
Merged
@mv-2112

mv-2112 commented Sep 11, 2026

Copy link
Copy Markdown
Author

Depends on #915

@hemanthnakkina

hemanthnakkina commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

@mv-2112 #915 is merged and this PR needs rebase

@mv-2112
feat: implement rating feature
a3554eb 
Implement initial rating feature deploying
upstream project CloudKitty.

This caters for the Cloudkitty charm recently updated to use storage v2 api.

Signed-off-by: Matt Verran <verranm76@gmail.com>

fix: db connections to 2 and risk level
fix: pep8 issues
fix: add imports for requires and risk
fix: organise imports
fix: typo and corrected feature gating
fix: remove unnecessary import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gboutry gboutry gboutry requested changes
@hemanthnakkina hemanthnakkina hemanthnakkina left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mv-2112 @hemanthnakkina @hmlanigan @gboutry