fix(sunbeam-python): skip endpoint prompt when manifest omits optional endpoints field - #908
Open
RaphaSilva470 wants to merge 5 commits into
Open
RaphaSilva470 wants to merge 5 commits into
RaphaSilva470 wants to merge 5 commits into
Conversation
RaphaSilva470
force-pushed
the
fix/endpoints-prompt-with-manifest
branch
from
August 26, 2026 20:32
c636f37 to
ec8dd17
Compare
|
Resolving a question on the bug as to whether |
Raven-182
reviewed
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a manifest install where you don't provide core.config.endpoints (as its optional as per https://canonical-openstack.readthedocs-hosted.com/en/latest/reference/manifest-file-reference/) it prompts for y/n, when it should use the default configuration.
This PR fixes the behavior by only firing the prompt when the manifest is not supplied and --accept-defaults is not passed. In case there is a manifest it uses the value passed by the manifest or use the default value (in case core.config.endpoints is not specified).
Assisted-By: Gemini Flash
Closes-bug: 2156599
The tests can be found in tests/unit/sunbeam/steps/test_openstack.py. There are 4 tests that cover all cases:
No manifest provided, prompts. (unchanged behaviour).
Manifest provided with no core.config.endpoints, does not prompt.
Manifest provided with core.config.endpoints, does not prompt.
--accept-defaults passed, does not prompt.
pytest tests/unit/sunbeam/steps/test_openstack.py::TestEndpointsConfigurationStepPrompt -v
For manual reproduction:
sunbeam cluster bootstrap --role compute,control,storage -m ./manifest.yaml