fix(sunbeam-python): Use Deployment Client to Determine LoadbalancerFeature Requirements - #920
Merged
Merged
Conversation
…eature Requirements The Loadbalancer feature was made generally available, which means on enablement the requires property attempts to communicate with the local clusterd UNIX socket. This socket is owned by the root user and snap_daemon group but the sunbeam CLI is invoked from the ubuntu user. Therefore, the read fails with Errno 13 Permission denied and the feature gating falls back to requiring secrets, which unintentionally pulls in vault as a dependency even when using the OVN loadbalancer rather than amphorae. The proposed change is to use the deployment client rather than the UNIX socket to correctly determine the configuration and requirements. LP: #2167289 Signed-off-by: Bryan Fraschetti <bryan.fraschetti@canonical.com>
bryanfraschetti
force-pushed
the
lp_2167289
branch
from
September 16, 2026 19:27
400f1b8 to
689b225
Compare
gboutry
reviewed
Sep 17, 2026
| return set() | ||
| try: | ||
| saved = questions.load_answers(Client.from_socket(), AMPHORA_CONFIG_SECTION) | ||
| saved = questions.load_answers( |
Collaborator
There was a problem hiding this comment.
Indeed, this is the right move, since depending on the deployment type, this will be either the socket or the mtls https client.
hemanthnakkina
approved these changes
Sep 17, 2026
hemanthnakkina
left a comment
hemanthnakkina
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix
gboutry
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Loadbalancer feature was made generally available, which means on its enablement, the requires property attempts to communicate with the local clusterd UNIX socket to obtain the configuration. This socket is owned by the root user and snap_daemon group but the sunbeam CLI is invoked from the ubuntu user. Therefore, the read fails with Errno 13 Permission denied and the feature gating falls back to requiring secrets, which unintentionally pulls in vault as a dependency even when using the OVN loadbalancer rather than amphorae.
The proposed change is to use the deployment client rather than the UNIX socket to correctly determine the configuration and requirements.
Assisted-By: GPT-5.6 Sol
Closes-bug: #2167289
Jira card: OPEN-4763
QA steps
openstack.sunbeam enable loadbalancerorsunbeam enable loadbalancer