nmt: Fix NmtSlave on a node without a heartbeat producer time#672
Merged
Conversation
The NMT state transition from INITIALISING to PRE-OPERATIONAL causes the heartbeat to start automatically if the parameter is non-zero in object 0x1017:00. This check however raises an exception if the object does not even exist. Cover this state in tests and explicitly ignore a KeyError when asking for the object.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bizfsc
approved these changes
Jun 24, 2026
bizfsc
left a comment
bizfsc
left a comment
Collaborator
There was a problem hiding this comment.
Minimal implementation to fix bug. approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NMT state transition from INITIALISING to PRE-OPERATIONAL causes the heartbeat to start automatically if the parameter is non-zero in object 0x1017:00. This check however raises an exception if the object does not even exist.
Cover this state in tests and explicitly ignore a KeyError when asking for the object.