Repository navigation
Rework of decider - #50
Open
sjnarmstrong wants to merge 1508 commits into
Open
sjnarmstrong wants to merge 1508 commits into
sjnarmstrong wants to merge 1508 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| yield f"data: {json.dumps({'type': 'error', 'error': f'Failed to preview table data: {e}'})}\n\n" | ||
|
|
||
| return StreamingResponse( | ||
| generate_preview_stream(), |
Comment on lines
+729
to
+732
| content={ | ||
| "message": "Project is invalid and cannot be exported", | ||
| "validation_errors": errors, | ||
| }, |
…s every 15 s, so a reader that never sends is cut off when its access ends
…(failing: the database refuses it, the socket drops and the client resends it for ever)
…hole instead of failing the write
…own once that version arrives (failing: it is passed on at once and the editor drops it)
… the polars engine refuses it instead of shifting the wall clock
…rsion, and dropped once it is behind
…offline batch and pings every 10 s to notice a dead connection
…eeps a banner naming the rules of a refused one with Download my version, and labels the reconnecting badge Offline
…t is stored (released together, the two sockets race for the row lock)
… never across time zones
… and three browsers, a dead connection, node two, a restart)
…nly its label (the label changes before the page loads)
…nflict (editors stamp the same defaults on every rule)
…0 edits on the 521-rule flat sets
…and the refused-batch banner
…cross backend nodes by Postgres LISTEN/NOTIFY (flat-rule editor; off unless DSP_LIVE_COLLAB)
# Conflicts: # ui/tree-editor/backend/dsp_decikit/api/v1/project/live.py # ui/tree-editor/backend/tests/test_live_sync.py # ui/tree-editor/ui/src/components/flat-rules/useFlatRuleLive.ts # ui/tree-editor/ui/src/lib/__tests__/live-sync.test.ts # ui/tree-editor/ui/src/lib/live-sync.ts
…ntains so the server skips one applied while the client reconnected; the log refuses a message twice
…server skips any already logged; a unique index logs a client's message once
…ckend and e2e), keeping each file under 500 lines
…sage sizes and codec time)
… insert put at that index is not the same change
…ames the same item on both sides
…atch that resent it, and a batch folded into a later one, apply once
…s it contains, so one delivered late is not applied again
… on what it changed; the live edit is dropped and its author told
…n what it changed (decision, README)
…ys open (strict xfail: the first connection stamps rule ids and redraws every rule card)
…until live editing has connected, and a flat tree's round trip renames a rule and back so the editor's form is saved as over REST
…ith live editing off; live, the refused branch removal is checked after a Save
… live test that covers each; a shared user's and a double export's later save wait for a live Save
…the server log under; a large live message after a REST save of every rule is checked quickly
…s, not one core call per pair; a live client may not take the id rest or server
…whole document (72 KB stored), offline batches merge past a save they don't overlap, a save still wins over earlier live edits on what it changed (reviewed)
…on; the stamp redraw among the known failures
…ithout rule ids redraws it, e2e stories without a live counterpart, a live Save waits for validation
…dated in time reports that, not Save Failed (red)
… validate in time says Saved, not validated yet, instead of Save Failed
…ersion in time says Saved, not validated yet
…wo nodes, flag-off unchanged; a live Save waits for its version's validation and says Saved, not validated yet when none comes (reviewed)
sjnarmstrong
force-pushed
the
feature/python-api-redesign
branch
from
October 23, 2026 16:39
d6f4080 to
a8b344c
Compare
…not sent to the browser; a data source's own error keeps its message (red)
…ported as an unexpected server error; a data source's own error keeps its message
…ython 3.10 and 3.11 (no nested double quotes in the f-string); its test checks the message
…not sent to the browser; the release token is read-only by default (reviewed; full e2e 616 passed live on, 607 off)
…eeval) extras, anyio and pytest-cov; all includes markdown-it-py
…, styled-components, web-vitals, http-proxy-middleware, stale types) and the Create React App proxy and web-vitals leftovers
…ndas or pyarrow in the lock), no unused extras, 21 unused UI packages gone (main suite 3758 passed; e2e 615-616 live on, 606-607 off, the two misses pass on rerun)
…old the edit unsaved on a live stack instead of racing its 150 ms send
… tests cut the edit off from the server (20 loaded runs and the file live on and off pass)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.