Improve utility code clarity and add CcpTruncateFile#29
Open
MiloPernemarkDEV wants to merge 5 commits into
Open
Improve utility code clarity and add CcpTruncateFile#29MiloPernemarkDEV wants to merge 5 commits into
MiloPernemarkDEV wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
CcpTruncateFileas an explicit API for clearing file contents. This avoids requiring users to know thatCcpCreateFileinternally uses_O_TRUNC, making the truncation behavior clearer at the call site.The current implementation reuses
CcpCreateFileto preserve the existing behavior and avoid duplicating file creation logic. If the preferred approach is to handle truncation directly insideCcpTruncateFile, I can adjust it.Additional cleanup:
constexprvalues for improved readability and maintainability.reinterpret_castin the time implementation to make the intent of the conversion explicit.