Skip to content

Added mirroring support for child meshes#25

Merged
JohnGreenFC merged 2 commits into
mainfrom
PLAT-11614-Mesh-mirroring-of-child-meshes
Jul 14, 2026
Merged

Added mirroring support for child meshes#25
JohnGreenFC merged 2 commits into
mainfrom
PLAT-11614-Mesh-mirroring-of-child-meshes

Conversation

@JohnGreenFC

Copy link
Copy Markdown
  • Removed old system for requesting reversed index buffers
  • Added support to read the transform of a mesh and reverse its index winding based on that

- Removed old system for requesting reversed index buffers
- Added support to read the transform of a mesh and reverse its index winding based on that
Copilot AI review requested due to automatic review settings July 13, 2026 16:24

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-format v20.1.2

Click here for the full clang-format patch
diff --git a/trinity/Eve/SpaceObject/Children/EveChildParticleSystem.cpp b/trinity/Eve/SpaceObject/Children/EveChildParticleSystem.cpp
index 81ffe20..8134510 100644
--- a/trinity/Eve/SpaceObject/Children/EveChildParticleSystem.cpp
+++ b/trinity/Eve/SpaceObject/Children/EveChildParticleSystem.cpp
@@ -199 +198,0 @@ void EveChildParticleSystem::UpdateSyncronous( const EveUpdateContext& updateCon
-

Have any feedback or feature suggestions? Share it here.

Comment thread trinity/Eve/SpaceObject/Children/EveChildParticleSystem.cpp Outdated
@github-actions github-actions Bot dismissed their stale review July 13, 2026 16:28

outdated suggestion

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Trinity’s mesh rendering path to support mirrored (reflected) child meshes by selecting reversed index winding at batch-build time based on the mesh transform, removing the prior “request reversed index buffers” mechanism.

Changes:

  • Added a reverseWinding/reverseAreas parameter to mesh batch generation so callers can flip winding per draw based on transform determinant.
  • Removed the legacy reversed-index-buffer request flow (ReverseIndexBuffers() / RequestReversedIndexBuffers()).
  • Updated geometry resource preparation to always generate reversed index buffers and account for their memory cost.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
trinity/Tr2MeshBase.h Extends GetBatches signature with reverseWinding; updates CreateGeometryBatch declaration.
trinity/Tr2MeshBase.cpp Propagates reverseWinding into batch creation; removes legacy reversed-index request logic.
trinity/Tr2MeshArea.cpp Removes automatic reversed-index-buffer requesting when an area becomes reversed.
trinity/Tr2Mesh.h Removes ReverseIndexBuffers() override from Tr2Mesh.
trinity/Tr2Mesh.cpp Removes reversed-index-buffer requesting in geometry resource setters and the ReverseIndexBuffers() implementation.
trinity/Tr2InstancedMesh.h Consolidates GetBatches overloads and adds reverseAreas default parameter.
trinity/Tr2InstancedMesh.cpp Removes legacy wrapper overload; keeps a single GetBatches with reverseAreas.
trinity/Resources/TriGeometryRes.h Removes RequestReversedIndexBuffers() API and the request-tracking flag.
trinity/Resources/TriGeometryRes.cpp Removes old request-time reversal; always builds reversed index buffers and updates memory accounting.
trinity/Eve/SpaceObject/Children/EveChildParticleSystem.cpp Removes per-update reversal request (render-time reversal already used).
trinity/Eve/SpaceObject/Children/EveChildMesh.cpp Computes transform determinant and passes reverseWinding into mesh batch generation for mirrored children and shadows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread trinity/Resources/TriGeometryRes.cpp
Comment thread trinity/Resources/TriGeometryRes.cpp
Comment thread trinity/Resources/TriGeometryRes.cpp
Comment thread trinity/Resources/TriGeometryRes.cpp
@JohnGreenFC JohnGreenFC merged commit 8d68bc9 into main Jul 14, 2026
13 checks passed
@JohnGreenFC JohnGreenFC deleted the PLAT-11614-Mesh-mirroring-of-child-meshes branch July 14, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants